Skip to content

Commit 3e55059

Browse files
author
Elias Naur
committed
cmd/dist: really skip the testsanitizers tests on Android
The test.bash script in misc/cgo/testsanitizers use GOOS, not GOHOSTOS. Fix the dist check from gohostos to goos accordingly. The error was masked on the builders because they run on a darwin host where the sanitizers tests never ran. With this change, the Android test suite completes successfully on Android/amd64. Change-Id: Id7690429f78c6ac7a26fc9118d913b719b565bb2 Reviewed-on: https://go-review.googlesource.com/35959 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Elias Naur <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 0949659 commit 3e55059

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/cmd/dist/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,7 @@ func (t *tester) registerTests() {
567567
if t.gohostos == "linux" && t.goarch == "amd64" {
568568
t.registerTest("testasan", "../misc/cgo/testasan", "go", "run", "main.go")
569569
}
570-
if t.gohostos == "linux" && t.goarch == "amd64" {
570+
if t.goos == "linux" && t.goarch == "amd64" {
571571
t.registerTest("testsanitizers", "../misc/cgo/testsanitizers", "./test.bash")
572572
}
573573
if t.hasBash() && t.goos != "android" && !t.iOS() && t.gohostos != "windows" {

0 commit comments

Comments
 (0)