Skip to content

Commit 4a0ce46

Browse files
committed
go/types: remove mode argument from the pkgFiles helper
This mode is now always 0. Remove the unnecessary argument to better align with types2. Change-Id: Ib59196a9dfc26fd66ae51381eabc760c39ad9ede Reviewed-on: https://go-review.googlesource.com/c/go/+/442775 Run-TryBot: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Robert Griesemer <[email protected]>
1 parent ddd8bc1 commit 4a0ce46

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/go/types/errorcalls_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const errorfMinArgCount = 4
1616
// errorfMinArgCount arguments (otherwise we should use check.error).
1717
func TestErrorCalls(t *testing.T) {
1818
fset := token.NewFileSet()
19-
files, err := pkgFiles(fset, ".", 0)
19+
files, err := pkgFiles(fset, ".")
2020
if err != nil {
2121
t.Fatal(err)
2222
}

src/go/types/lookup_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func BenchmarkLookupFieldOrMethod(b *testing.B) {
2222
path := filepath.Join(runtime.GOROOT(), "src", "net", "http")
2323

2424
fset := token.NewFileSet()
25-
files, err := pkgFiles(fset, path, 0)
25+
files, err := pkgFiles(fset, path)
2626
if err != nil {
2727
b.Fatal(err)
2828
}

src/go/types/self_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import (
1919

2020
func TestSelf(t *testing.T) {
2121
fset := token.NewFileSet()
22-
files, err := pkgFiles(fset, ".", 0)
22+
files, err := pkgFiles(fset, ".")
2323
if err != nil {
2424
t.Fatal(err)
2525
}
@@ -61,7 +61,7 @@ func BenchmarkCheck(b *testing.B) {
6161

6262
func runbench(b *testing.B, path string, ignoreFuncBodies, writeInfo bool) {
6363
fset := token.NewFileSet()
64-
files, err := pkgFiles(fset, path, 0)
64+
files, err := pkgFiles(fset, path)
6565
if err != nil {
6666
b.Fatal(err)
6767
}
@@ -98,15 +98,15 @@ func runbench(b *testing.B, path string, ignoreFuncBodies, writeInfo bool) {
9898
b.ReportMetric(float64(lines)*float64(b.N)/time.Since(start).Seconds(), "lines/s")
9999
}
100100

101-
func pkgFiles(fset *token.FileSet, path string, mode parser.Mode) ([]*ast.File, error) {
101+
func pkgFiles(fset *token.FileSet, path string) ([]*ast.File, error) {
102102
filenames, err := pkgFilenames(path) // from stdlib_test.go
103103
if err != nil {
104104
return nil, err
105105
}
106106

107107
var files []*ast.File
108108
for _, filename := range filenames {
109-
file, err := parser.ParseFile(fset, filename, nil, mode)
109+
file, err := parser.ParseFile(fset, filename, nil, 0)
110110
if err != nil {
111111
return nil, err
112112
}

0 commit comments

Comments
 (0)