Skip to content

Commit 5647d01

Browse files
author
Bryan C. Mills
committed
Revert "net/http: test that ParseMultipartForm returns an error for int overflow"
This reverts CL 254977. Reason for revert: introduced test failures on longtest builders. Change-Id: I75e868245f980189ad85dd4103d9178989e06ecf Reviewed-on: https://go-review.googlesource.com/c/go/+/263658 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 4d1cecd commit 5647d01

File tree

1 file changed

+0
-36
lines changed

1 file changed

+0
-36
lines changed

src/net/http/request_test.go

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"fmt"
1414
"io"
1515
"io/ioutil"
16-
"math"
1716
"mime/multipart"
1817
. "net/http"
1918
"net/http/httptest"
@@ -246,41 +245,6 @@ func TestParseMultipartForm(t *testing.T) {
246245
}
247246
}
248247

249-
// Issue #40430: ParseMultipartForm should return error for int overflow
250-
func TestMaxInt64ForMultipartFormMaxMemory(t *testing.T) {
251-
cst := httptest.NewServer(HandlerFunc(func(rw ResponseWriter, req *Request) {
252-
if err := req.ParseMultipartForm(math.MaxInt64); err != nil {
253-
Error(rw, err.Error(), StatusBadRequest)
254-
return
255-
}
256-
}))
257-
defer cst.Close()
258-
fBuf := new(bytes.Buffer)
259-
mw := multipart.NewWriter(fBuf)
260-
mf, err := mw.CreateFormFile("file", "myfile.txt")
261-
if err != nil {
262-
t.Fatal(err)
263-
}
264-
if _, err := mf.Write(bytes.Repeat([]byte("abc"), 1<<10)); err != nil {
265-
t.Fatal(err)
266-
}
267-
if err := mw.Close(); err != nil {
268-
t.Fatal(err)
269-
}
270-
req, err := NewRequest("POST", cst.URL, fBuf)
271-
if err != nil {
272-
t.Fatal(err)
273-
}
274-
req.Header.Set("Content-Type", mw.FormDataContentType())
275-
res, err := cst.Client().Do(req)
276-
if err != nil {
277-
t.Fatal(err)
278-
}
279-
if g, w := res.StatusCode, StatusBadRequest; g != w {
280-
t.Fatalf("Status code mismatch: got %d, want %d", g, w)
281-
}
282-
}
283-
284248
func TestRedirect_h1(t *testing.T) { testRedirect(t, h1Mode) }
285249
func TestRedirect_h2(t *testing.T) { testRedirect(t, h2Mode) }
286250
func testRedirect(t *testing.T, h2 bool) {

0 commit comments

Comments
 (0)