cmd/go: set GO111MODULE=off explicitly in tests that assume GOPATH mode

We will soon switch GO111MODULE to 'on' by default, and when that
happens these tests will otherwise break.

Updates #30228

Change-Id: I1016d429b1dfb889d1aae8bc86fb2567cf0fc56f
Reviewed-on: https://go-review.googlesource.com/c/162697
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>

Author: Bryan C. Mills

src/cmd/go/go_test.go

@@ -394,6 +394,7 @@ func (tg *testgoData) setenv(name, val string) {
 func (tg *testgoData) unsetenv(name string) {
 	if tg.env == nil {
 		tg.env = append([]string(nil), os.Environ()...)
+		tg.env = append(tg.env, "GO111MODULE=off")
 	}
 	for i, v := range tg.env {
 		if strings.HasPrefix(v, name+"=") {

src/cmd/go/testdata/script/binary_only.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # check that error for missing binary-only says where it should be
 ! go build b
 stderr pkg[\\/].*a\.a

src/cmd/go/testdata/script/build_GOTMPDIR.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Set GOCACHE to a clean directory to ensure that 'go build' has work to report.
 env GOCACHE=$WORK/gocache
 

src/cmd/go/testdata/script/build_cache_compile.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Set up fresh GOCACHE.
 env GOCACHE=$WORK/gocache
 mkdir $GOCACHE

src/cmd/go/testdata/script/build_cache_gomips.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Set up fresh GOCACHE.
 env GOCACHE=$WORK/gocache
 mkdir $GOCACHE

src/cmd/go/testdata/script/build_cache_link.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Set up fresh GOCACHE.
 env GOCACHE=$WORK/gocache
 mkdir $GOCACHE

src/cmd/go/testdata/script/build_cache_output.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!gc] skip
 
 # Set up fresh GOCACHE.

src/cmd/go/testdata/script/build_nocache.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # As of Go 1.12, the module cache is required.
 
 # If none of the variables we use to locate GOCACHE are set, the cache is off

src/cmd/go/testdata/script/build_relative_pkgdir.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Regression test for golang.org/issue/21309: accept relative -pkgdir argument.
 
 [short] skip

src/cmd/go/testdata/script/build_relative_tmpdir.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # If GOTMPDIR is relative, 'go build' should derive an absolute $WORK directory.
 cd $WORK
 mkdir tmp

src/cmd/go/testdata/script/build_runtime_gcflags.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Set up fresh GOCACHE.
 env GOCACHE=$WORK/gocache
 mkdir $GOCACHE

src/cmd/go/testdata/script/cache_unix.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Integration test for cache directory calculation (cmd/go/internal/cache).
 
 [windows] skip

src/cmd/go/testdata/script/cgo_syso_issue29253.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # This test tests that we can link in-package syso files that provides symbols
 # for cgo. See issue 29253.
 [!cgo] stop

src/cmd/go/testdata/script/clean_testcache.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go clean -testcache
 # should work (see golang.org/issue/29757).
 cd x

src/cmd/go/testdata/script/cover_atomic_pkgall.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [short] skip
 
 go test -coverpkg=all -covermode=atomic x

src/cmd/go/testdata/script/cover_pkgall_runtime.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Issue 23882
 
 [short] skip

src/cmd/go/testdata/script/cpu_profile_twice.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Issue 23150
 
 [short] skip

src/cmd/go/testdata/script/fileline.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # look for short, relative file:line in error message
 ! go run ../../gopath/x/y/z/err.go
 stderr ^..[\\/]x[\\/]y[\\/]z[\\/]err.go:

src/cmd/go/testdata/script/gcflags_patterns.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!gc] skip 'using -gcflags and -ldflags'
 
 # -gcflags=-e applies to named packages, not dependencies

src/cmd/go/testdata/script/get_brace.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!exec:git] skip
 
 # Set up some empty repositories.

src/cmd/go/testdata/script/get_dotfiles.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!exec:git] skip
 
 # Set up a benign repository and a repository with a dotfile name.

src/cmd/go/testdata/script/get_tilde.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Paths containing windows short names should be rejected before attempting to fetch.
 ! go get example.com/longna~1.dir/thing
 stderr 'trailing tilde and digits'

src/cmd/go/testdata/script/get_unicode.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!exec:git] skip
 
 # Construct a repository that imports a non-ASCII path.

src/cmd/go/testdata/script/get_with_git_trace.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 env GIT_TRACE=1
 
 [!net] skip

src/cmd/go/testdata/script/goflags.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # GOFLAGS sets flags for commands
 
 env GOFLAGS='-e -f={{.Dir}} --test.benchtime=1s -count=10'

src/cmd/go/testdata/script/help.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go help shows overview.
 go help
 stdout 'Go is a tool'

src/cmd/go/testdata/script/install_cleans_build.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # 'go install' with no arguments should clean up after go build
 cd mycmd
 go build

src/cmd/go/testdata/script/install_cross_gobin.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 cd mycmd
 go build mycmd
 

src/cmd/go/testdata/script/install_rebuild_gopath.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # GOPATH with p1 in d1, p2 in d2
 env GOPATH=$WORK/d1${:}$WORK/d2
 

src/cmd/go/testdata/script/install_rebuild_removed.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go command should detect package staleness as source file set changes
 go install mypkg
 ! stale mypkg

src/cmd/go/testdata/script/linkname.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # check for linker name in error message about linker crash
 [!gc] skip
 ! go build -ldflags=-crash_for_testing x.go

src/cmd/go/testdata/script/list_bad_import.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # This test matches mod_list_bad_import, but in GOPATH mode.
 # Please keep them in sync.
 

src/cmd/go/testdata/script/list_compiled_imports.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!cgo] skip
 
 # go list should report import "C"

src/cmd/go/testdata/script/list_find.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go list -find should not report imports
 
 go list -f {{.Incomplete}} x/y/z...  # should probably exit non-zero but never has

src/cmd/go/testdata/script/list_importmap.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # gccgo does not have standard packages.
 [gccgo] skip
 

src/cmd/go/testdata/script/list_std.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!gc] skip
 
 # listing GOROOT should only find standard packages

src/cmd/go/testdata/script/list_tags.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go list supports -tags
 go list -tags=thetag ./my...
 stdout mypkg

src/cmd/go/testdata/script/list_test_e.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # issue 25980: crash in go list -e -test
 go list -e -test -f '{{.Error}}' p
 stdout '^p[/\\]d_test.go:2:8: cannot find package "d" in any of:'

src/cmd/go/testdata/script/list_test_imports.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # issue 26880: list with tests has wrong variant in imports
 go list -test -f '{{.ImportPath}}:{{with .Imports}} {{join . ", "}}{{end}}' a b
 cmp stdout imports.txt

src/cmd/go/testdata/script/mod_find.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=auto
+
 # Derive module path from import comment.
 cd $WORK/x
 exists x.go

src/cmd/go/testdata/script/mod_gobuild_import.txt

@@ -7,22 +7,19 @@ env GO111MODULE=off
 ! exec $WORK/testimport.exe x/y/z/w .
 
 # GO111MODULE=auto in GOPATH/src
-env GO111MODULE=
-! exec $WORK/testimport.exe x/y/z/w .
 env GO111MODULE=auto
 ! exec $WORK/testimport.exe x/y/z/w .
 
 # GO111MODULE=auto outside GOPATH/src
 cd $GOPATH/other
-env GO111MODULE=
+env GO111MODULE=auto
 exec $WORK/testimport.exe other/x/y/z/w .
 stdout w2.go
 
 ! exec $WORK/testimport.exe x/y/z/w .
 stderr 'cannot find module providing package x/y/z/w'
 
 cd z
-env GO111MODULE=auto
 exec $WORK/testimport.exe other/x/y/z/w .
 stdout w2.go
 
@@ -33,6 +30,7 @@ stdout w2.go
 
 # GO111MODULE=on in GOPATH/src
 cd $GOPATH/src
+env GO111MODULE=on
 exec $WORK/testimport.exe x/y/z/w .
 stdout w1.go
 cd w

src/cmd/go/testdata/script/pattern_syntax_error.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # patterns match directories with syntax errors
 ! go list ./...
 ! go build ./...

src/cmd/go/testdata/script/run_hello.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # hello world
 go run hello.go
 stderr 'hello world'

src/cmd/go/testdata/script/run_wildcard.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Fix for https://github.com/golang/go/issues/28696:
 # go run x/... should not panic when directory x doesn't exist.
 

src/cmd/go/testdata/script/script_wait.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 [!exec:echo] skip
 [!exec:false] skip
 

src/cmd/go/testdata/script/test_badtest.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 ! go test badtest/...
 ! stdout ^ok
 stdout ^FAIL\tbadtest/badexec

src/cmd/go/testdata/script/test_compile_binary.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 ! go test -c compile_binary/...
 stderr 'build comment'
 

src/cmd/go/testdata/script/test_devnull.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # go test -c -o NUL
 # should work (see golang.org/issue/28035).
 cd x

src/cmd/go/testdata/script/vendor_complex.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # smoke test for complex build configuration
 go build -o complex.exe complex
 [exec:gccgo] go build -compiler=gccgo -o complex.exe complex

src/cmd/go/testdata/script/vet_asm.txt

@@ -1,3 +1,5 @@
+env GO111MODULE=off
+
 # Issue 27665. Verify that "go vet" analyzes non-Go files.
 
 env GOOS=linux