Skip to content

Commit 7b5d536

Browse files
committed
net: ensure that ResolveIPAddr(addr.String()) reproduces addr
Updates #6465. Change-Id: I5babbcf4c92dae47c823a41628b01e4ceb2332eb Reviewed-on: https://go-review.googlesource.com/11951 Run-TryBot: Mikio Hara <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent a625b91 commit 7b5d536

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/net/ipraw_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ var resolveIPAddrTests = []resolveIPAddrTest{
3838
{"", "127.0.0.1", &IPAddr{IP: IPv4(127, 0, 0, 1)}, nil}, // Go 1.0 behavior
3939
{"", "::1", &IPAddr{IP: ParseIP("::1")}, nil}, // Go 1.0 behavior
4040

41+
{"ip4:icmp", "", &IPAddr{}, nil},
42+
4143
{"l2tp", "127.0.0.1", nil, UnknownNetworkError("l2tp")},
4244
{"l2tp:gre", "127.0.0.1", nil, UnknownNetworkError("l2tp:gre")},
4345
{"tcp", "1.2.3.4:123", nil, UnknownNetworkError("tcp")},

src/net/iprawsock.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,11 @@ func (a *IPAddr) String() string {
1717
if a == nil {
1818
return "<nil>"
1919
}
20+
ip := ipEmptyString(a.IP)
2021
if a.Zone != "" {
21-
return a.IP.String() + "%" + a.Zone
22+
return ip + "%" + a.Zone
2223
}
23-
return a.IP.String()
24+
return ip
2425
}
2526

2627
func (a *IPAddr) isWildcard() bool {

0 commit comments

Comments
 (0)