Skip to content

Commit 7f36ef0

Browse files
committed
cmd/compile/internal/noder: hide TestUnifiedCompare behind -cmp flag
This test is fragile and is starting to impede others' work. This CL disables it until I have time to either find a solution for the issues or decide to just delete the test altogether. Change-Id: Icefabb6d3fbedec5d16536de78be4ca20d63133c Reviewed-on: https://go-review.googlesource.com/c/go/+/350729 Trust: Matthew Dempsky <[email protected]> Trust: Dan Scales <[email protected]> Run-TryBot: Matthew Dempsky <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Dan Scales <[email protected]>
1 parent 70493b3 commit 7f36ef0

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/cmd/compile/internal/noder/unified_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
)
1717

1818
var (
19+
flagCmp = flag.Bool("cmp", false, "enable TestUnifiedCompare")
1920
flagPkgs = flag.String("pkgs", "std", "list of packages to compare (ignored in -short mode)")
2021
flagAll = flag.Bool("all", false, "enable testing of all GOOS/GOARCH targets")
2122
flagParallel = flag.Bool("parallel", false, "test GOOS/GOARCH targets in parallel")
@@ -37,6 +38,12 @@ var (
3738
// command's -run flag for subtest matching is recommended for less
3839
// powerful machines.
3940
func TestUnifiedCompare(t *testing.T) {
41+
// TODO(mdempsky): Either re-enable or delete. Disabled for now to
42+
// avoid impeding others' forward progress.
43+
if !*flagCmp {
44+
t.Skip("skipping TestUnifiedCompare (use -cmp to enable)")
45+
}
46+
4047
targets, err := exec.Command("go", "tool", "dist", "list").Output()
4148
if err != nil {
4249
t.Fatal(err)

0 commit comments

Comments
 (0)