Skip to content

Commit 81a4fe6

Browse files
committed
cmd/link/internal/ld: re-enable DWARF tests on solaris/illumos
It looks like these are fixed on current tip after CL 84655 marked them to be skipped. Fixes #23168 Change-Id: I0020e6da1042f723eb54186ef0fe925df5326230 Reviewed-on: https://go-review.googlesource.com/c/go/+/349250 Trust: Tobias Klauser <[email protected]> Run-TryBot: Tobias Klauser <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Than McIntosh <[email protected]> TryBot-Result: Go Bot <[email protected]>
1 parent f93a63a commit 81a4fe6

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

src/cmd/link/internal/ld/dwarf_test.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -614,9 +614,6 @@ func TestInlinedRoutineRecords(t *testing.T) {
614614
if runtime.GOOS == "plan9" {
615615
t.Skip("skipping on plan9; no DWARF symbol table in executables")
616616
}
617-
if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
618-
t.Skip("skipping on solaris, illumos, pending resolution of issue #23168")
619-
}
620617

621618
t.Parallel()
622619

@@ -851,9 +848,6 @@ func TestAbstractOriginSanity(t *testing.T) {
851848
if runtime.GOOS == "plan9" {
852849
t.Skip("skipping on plan9; no DWARF symbol table in executables")
853850
}
854-
if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
855-
t.Skip("skipping on solaris, illumos, pending resolution of issue #23168")
856-
}
857851

858852
if wd, err := os.Getwd(); err == nil {
859853
gopathdir := filepath.Join(wd, "testdata", "httptest")
@@ -869,9 +863,6 @@ func TestAbstractOriginSanityIssue25459(t *testing.T) {
869863
if runtime.GOOS == "plan9" {
870864
t.Skip("skipping on plan9; no DWARF symbol table in executables")
871865
}
872-
if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
873-
t.Skip("skipping on solaris, illumos, pending resolution of issue #23168")
874-
}
875866
if runtime.GOARCH != "amd64" && runtime.GOARCH != "386" {
876867
t.Skip("skipping on not-amd64 not-386; location lists not supported")
877868
}
@@ -890,9 +881,6 @@ func TestAbstractOriginSanityIssue26237(t *testing.T) {
890881
if runtime.GOOS == "plan9" {
891882
t.Skip("skipping on plan9; no DWARF symbol table in executables")
892883
}
893-
if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
894-
t.Skip("skipping on solaris, illumos, pending resolution of issue #23168")
895-
}
896884
if wd, err := os.Getwd(); err == nil {
897885
gopathdir := filepath.Join(wd, "testdata", "issue26237")
898886
abstractOriginSanity(t, gopathdir, DefaultOpt)

0 commit comments

Comments
 (0)