Skip to content

Commit b6473ff

Browse files
committed
cmd/dist: run wiki, shootout etc tests only on builders
These find approximately nothing. Takes 5% off my all.bash run time. For #10571. Change-Id: I21d3a844af756eb37f59bba0064f24995626da0d Reviewed-on: https://go-review.googlesource.com/18198 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent baa928a commit b6473ff

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/cmd/dist/test.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,10 @@ func (t *tester) registerTests() {
499499
t.registerTest("testsigfwd", "../misc/cgo/testsigfwd", "go", "run", "main.go")
500500
}
501501
}
502-
if t.hasBash() && t.goos != "nacl" && t.goos != "android" && !t.iOS() {
502+
503+
// Doc and shootout tests only run on builders.
504+
// They find problems approximately never.
505+
if t.hasBash() && t.goos != "nacl" && t.goos != "android" && !t.iOS() && os.Getenv("GO_BUILDER_NAME") != "" {
503506
t.registerTest("doc_progs", "../doc/progs", "time", "go", "run", "run.go")
504507
t.registerTest("wiki", "../doc/articles/wiki", "./test.bash")
505508
t.registerTest("codewalk", "../doc/codewalk", "time", "./run")
@@ -517,6 +520,7 @@ func (t *tester) registerTests() {
517520
t.registerSeqTest("shootout:"+name, "../test/bench/shootout", "time", "./timing.sh", "-test", name)
518521
}
519522
}
523+
520524
if t.goos != "android" && !t.iOS() {
521525
t.registerTest("bench_go1", "../test/bench/go1", "go", "test", t.timeout(600))
522526
}

0 commit comments

Comments
 (0)