runtime: temporarily skip gdb python-related tests on illumos

jclulow · bradfitz · commit d960de0b6f61 · 2019-10-21T05:11:52.000Z
Updates #20821 Change-Id: I186356a78ac385a15b4604e0ea6110c4c212ebc4 Reviewed-on: https://go-review.googlesource.com/c/go/+/202357 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go
@@ -66,8 +66,8 @@ func checkGdbVersion(t *testing.T) {
 }
 
 func checkGdbPython(t *testing.T) {
-	if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" {
-		t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821")
+	if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" {
+		t.Skip("skipping gdb python tests on illumos and solaris; see golang.org/issue/20821")
 	}
 
 	cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ func checkGdbVersion(t *testing.T) {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`func checkGdbPython(t *testing.T) {`
`69`		`- if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" {`
`70`		`- t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821")`
	`69`	`+ if runtime.GOOS == "solaris" \|\| runtime.GOOS == "illumos" {`
	`70`	`+ t.Skip("skipping gdb python tests on illumos and solaris; see golang.org/issue/20821")`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")`