Skip to content

Commit dbd22c7

Browse files
author
Bryan C. Mills
committed
cmd/dist: skip API check on plan9 builders
The plan9-arm builder has a very slow filesystem and frequently times out on this test. The api check verifies the API for all supported GOOS/GOARCH/CGO_ENABLED combination anyway, so if we skip it on one builder (or even most builders) there should be no loss of coverage. Updates #37951 Change-Id: I86a93df2ec60a6af6d942e3954eef09ce67bb39e Reviewed-on: https://go-review.googlesource.com/c/go/+/225662 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent 69d3a34 commit dbd22c7

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/cmd/dist/test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,12 @@ func (t *tester) registerTests() {
741741
})
742742
}
743743
}
744-
if goos != "android" && !t.iOS() && goos != "js" {
744+
// Only run the API check on fast development platforms. Android, iOS, and JS
745+
// are always cross-compiled, and the filesystems on our only plan9 builders
746+
// are too slow to complete in a reasonable timeframe. Every platform checks
747+
// the API on every GOOS/GOARCH/CGO_ENABLED combination anyway, so we really
748+
// only need to run this check once anywhere to get adequate coverage.
749+
if goos != "android" && !t.iOS() && goos != "js" && goos != "plan9" {
745750
t.tests = append(t.tests, distTest{
746751
name: "api",
747752
heading: "API check",

0 commit comments

Comments
 (0)