crypto/x509: add missing be to comment about serial number positivity

geemus · gopherbot · commit e5489a34ca2c · 2024-12-02T17:03:18.000Z
Change-Id: I4e0e5309eb3cb1c6820f1a034a5f52adffe35645 GitHub-Last-Rev: 74b2e89 GitHub-Pull-Request: #70639 Reviewed-on: https://go-review.googlesource.com/c/go/+/632815 Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Roland Shoemaker <roland@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/src/crypto/x509/x509.go b/src/crypto/x509/x509.go
@@ -1694,7 +1694,7 @@ func CreateCertificate(rand io.Reader, template, parent *Certificate, pub, priv
 		}
 	}
 
-	// RFC 5280 Section 4.1.2.2: serial number must positive
+	// RFC 5280 Section 4.1.2.2: serial number must be positive
 	//
 	// We _should_ also restrict serials to <= 20 octets, but it turns out a lot of people
 	// get this wrong, in part because the encoding can itself alter the length of the

Original file line number	Diff line number	Diff line change
`@@ -1694,7 +1694,7 @@ func CreateCertificate(rand io.Reader, template, parent *Certificate, pub, priv`
`1694`	`1694`	`}`
`1695`	`1695`	`}`
`1696`	`1696`
`1697`		`- // RFC 5280 Section 4.1.2.2: serial number must positive`
	`1697`	`+ // RFC 5280 Section 4.1.2.2: serial number must be positive`
`1698`	`1698`	`//`
`1699`	`1699`	`// We _should_ also restrict serials to <= 20 octets, but it turns out a lot of people`
`1700`	`1700`	`// get this wrong, in part because the encoding can itself alter the length of the`