cmd/go: migrate away from semver.Max

Jay Conrod · Jay Conrod · commit e75aef80ca37 · 2020-11-12T14:17:24.000Z
For #32700 Change-Id: Ib5cd7004e4558bebebc5f9e7c9263d720c590845 Reviewed-on: https://go-review.googlesource.com/c/go/+/269338 Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
diff --git a/src/cmd/go/internal/modfetch/cache.go b/src/cmd/go/internal/modfetch/cache.go
@@ -483,7 +483,7 @@ func readDiskStatByHash(path, rev string) (file string, info *RevInfo, err error
 	for _, name := range names {
 		if strings.HasSuffix(name, suffix) {
 			v := strings.TrimSuffix(name, ".info")
-			if IsPseudoVersion(v) && semver.Max(maxVersion, v) == v {
+			if IsPseudoVersion(v) && semver.Compare(v, maxVersion) > 0 {
 				maxVersion = v
 				file, info, err = readDiskStat(path, strings.TrimSuffix(name, ".info"))
 			}

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ func readDiskStatByHash(path, rev string) (file string, info *RevInfo, err error`
`483`	`483`	`for _, name := range names {`
`484`	`484`	`if strings.HasSuffix(name, suffix) {`
`485`	`485`	`v := strings.TrimSuffix(name, ".info")`
`486`		`- if IsPseudoVersion(v) && semver.Max(maxVersion, v) == v {`
	`486`	`+ if IsPseudoVersion(v) && semver.Compare(v, maxVersion) > 0 {`
`487`	`487`	`maxVersion = v`
`488`	`488`	`file, info, err = readDiskStat(path, strings.TrimSuffix(name, ".info"))`
`489`	`489`	`}`