cmd/godoc: missing some functions when using dot imports

[nodirt]

Given

package x

import . "y"

// assume Y is defined in package y.

func F(Y) {}

func G() Y {
  return nil
}

godoc will displayF, but not G.

Repro: https://godoc.org/github.com/nodirt/tmp/godoc-bug should display function X.

[rsc]

Is this really about go/doc (the package)? It doesn't look like it.

[rsc]

/cc @griesemer fascinating

[nodirt]

FWIU, the root cause lies somewhere under https://godoc.org/go/doc#New

[griesemer]

This is indeed an issue with go/doc: The function G() Y is associated with type Y (as a "constructor") but Y is not locally declared and thus its associated constructors are never emitted.

(dot imports are not worth the trouble they've caused overall)

[gopherbot]

CL https://golang.org/cl/18393 mentions this issue.