net/http: canceled requests with Timeout set always return a Timeout error

[FiloSottile]

Please answer these questions before submitting your issue. Thanks!

1. What version of Go are you using (go version)?

go version devel +9e8fa1e Fri Jun 17 15:18:39 2016 +0000 darwin/amd64

1. What did you do?

Make a http.Client with a Timeout. Cancel the request.

https://play.golang.org/p/v-QbAxdj-3

1. What did you expect to see?

If the cause was not a Client.Timeout, then the error should be left alone.

net/http: request canceled

1. What did you see instead?

The error is

net/http: request canceled (Client.Timeout exceeded while reading body)

---

This is because reqWasCanceled returns true whatever the reason for the cancelation is, be it a library user cancel or a Timeout. Then cancelTimerBody.Read uses that function to add the message.

The (Client.Timeout exceeded while awaiting headers) message is more likely to be correct (even if slightly racy), because it only adds the message if !deadline.IsZero() && !time.Now().Before(deadline).

[FiloSottile]

Looking into it, this is not only the error message. The error is actually a net Timeout.

[gopherbot]

CL https://golang.org/cl/24230 mentions this issue.

[bradfitz]

@FiloSottile, is this a regression from Go 1.6?

[FiloSottile]

Yep, it's a regression. I'll address the points on the CL now, sorry for the delay, I've been offline for a bit.

[odeke-em]

I've updated @FiloSottile's CL https://golang.org/cl/24230 with https://go-review.googlesource.com/32478.

[gopherbot]

CL https://golang.org/cl/32478 mentions this issue.

[KingRider]

go/src/net/http/client.go

Line 301 in 7448eb4

return stopTimer, timedOut.isSet

is wrong!

Check L303
https://go-review.googlesource.com/#/c/32478/1/src/net/http/client.go@303

Please is what correct? But a continue problem

net/http: TLS handshake timeout

[bradfitz]

@KingRider, we don't track comments on closed issues. Please file a new bug if you have a reproducible problem with the Go master branch.

[keitaj]

Where is cancelTimerBody.Read used?

[bradfitz]

@keitaj, we don't track comments on closed issues. Please file a new bug if you have a reproducible problem with the Go master branch.