Regression on Darwin: go fails to build

[gopherbot]

by seanerussell:

Revision 0e960179c82e appears to have introduced a regression on Darwin, which causes Go
to not build on OSX.  The previous revision, c63f30ac7770, builds cleanly.

* Xcode 3.2.5
* OSX 10.6.7

Running Mercurials "bisect" on the code, and using "all.bash" as the
litmus produced this:

...
install runtime/cgo
INSTALL FAIL runtime/cgo
8g  -o _go_.8 cgo.go
8c -FVw -o "iscgo.8" iscgo.c
8c -FVw -o "callbacks.8" callbacks.c
echo 'int main() { return 0; }' >_cgo_main.c
gcc -m32 -g -O2 -fPIC -o 386.o -c 386.S
gcc -m32 -g -O2 -fPIC -o darwin_386.o -c darwin_386.c
gcc -m32 -g -O2 -fPIC -o util.o -c util.c
darwin_386.c: In function 'libcgo_sys_thread_start':
darwin_386.c:123: error: 'error' undeclared (first use in this function)
darwin_386.c:123: error: (Each undeclared identifier is reported only once
darwin_386.c:123: error: for each function it appears in.)
darwin_386.c:123: warning: format '%s' expects type 'char *', but argument 3 has type
'int'
make[1]: *** [darwin_386.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [runtime/cgo.install] Error 1
make: *** Waiting for unfinished jobs....
Changeset 8908:0e960179c82e: bad
The first bad revision is:
changeset:   8908:0e960179c82e
user:        Albert Strasheim <[email protected]>
date:        Tue Jun 28 12:04:50 2011 -0400
summary:     runtime/cgo: check for errors from pthread_create


To reproduce, on OSX:

     hg clone -u 0e960179c82e https://go.googlecode.com/hg/
     cd hg/src
     ./all.bash

[gopherbot]

Comment 1 by seanerussell:

The bisect.state may or may not be useful:
bad 2efa68a4183d3de0d8b19ba863acc44090b3e878
bad 2efa68a4183d3de0d8b19ba863acc44090b3e878
bad b9ed2ef00448dc61eaa2cf1ff4a55ead9e5ffba6
bad 0e960179c82e2710fd73efbea45c0c68fa949d72
good 9b9b14702ff186cd5ef3a88a9cb84d6db6f50582
good eaa696629d4d469361dc53ff7bb1f7545fd0dfd1
good 5e7ad769e69f30de23d6af1bd38a1af80a1f6397
good c63f30ac777043a5d74e12330de5db080f1cd56a

[gopherbot]

Comment 2 by seanerussell:

<sigh>  Sorry.  I just noticed the "build status" page; you're already aware of
the failures.

[adg]

Comment 3:

Yeah. You need only report breakages for weekly/release tags.
http://godashboard.appspot.com/

Status changed to Retracted.

[gopherbot]

Comment 4 by seanerussell:

Is it worth submitting a patch for things like this?

[adg]

Comment 5:

It is, yeah. But it's already fixed:
https://code.google.com/p/go/source/detail?r=a1541ae18b69f6bed96248d6c88673576f474c0e
The process for submitting code is here:
http://golang.org/doc/contribute.html