x/tools/cmd/rename: tests are failing for Go 1.7 and Go 1.8

[bradfitz]

x/tools/cmd/rename tests are failing on https://build.golang.org for Go 1.7 and Go 1.8:

--- FAIL: TestGeneratedFiles (2.21s)
	gorename_test.go:270: 0: -from "\"mytest\"::f" -to "g": received unexpected error exit status 1
	gorename_test.go:274: 0: -from "\"mytest\"::f" -to "g": unexpected command output: gorename: can't find package "mytest"
		 (want: Renamed 1 occurrence in 1 file in 1 package.)
	gorename_test.go:274: 1: -from "\"mytest\"::f" -to "g": unexpected command output: gorename: can't find package "mytest"
		 (want: conflicts with func in same block)
	gorename_test.go:274: 2: -from "\"mytest\"::f" -to "g": unexpected command output: gorename: can't find package "mytest"
		 (want: gorename: refusing to modify generated file containing DO NOT EDIT marker:)
	gorename_test.go:274: 3: -from "mytest/0.go::f" -to "g": unexpected command output: gorename: can't find package containing /var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/gorename-regtest-753833277/src/mytest/0.go
		 (want: gorename: refusing to modify generated file containing DO NOT EDIT marker:)
	gorename_test.go:274: 4: -offset "main/0.go:#78" -to "bar": unexpected command output: gorename: can't find package containing /var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/gorename-regtest-753833277/src/main/0.go
		 (want: cannot rename identifiers in generated file containing DO NOT EDIT marker:)
	gorename_test.go:274: 5: -from "\"test\"::Foo" -to "Bar": unexpected command output: gorename: can't find package "test"
		 (want: gorename: refusing to modify generated file containing DO NOT EDIT marker:)
	gorename_test.go:270: 6: -from "\"test\".Foo::x" -to "y": received unexpected error exit status 1
	gorename_test.go:274: 6: -from "\"test\".Foo::x" -to "y": unexpected command output: gorename: can't find package "test"
		 (want: Renamed 2 occurrences in 1 file in 1 package.)
	gorename_test.go:274: 7: -from "\"mytest\"::f" -to "g": unexpected command output: gorename: can't find package "mytest"
		 (want: gorename: refusing to modify generated files containing DO NOT EDIT marker:)
	gorename_test.go:270: 8: -from "mytest/0.go::f" -to "g": received unexpected error exit status 1
	gorename_test.go:274: 8: -from "mytest/0.go::f" -to "g": unexpected command output: gorename: can't find package containing /var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/gorename-regtest-753833277/src/mytest/0.go
		 (want: Renamed 1 occurrence in 1 file in 1 package.)
	gorename_test.go:270: 9: -from "\"test\".Foo" -to "Bar": received unexpected error exit status 1
	gorename_test.go:274: 9: -from "\"test\".Foo" -to "Bar": unexpected command output: gorename: can't find package "test"
		 (want: Renamed 2 occurrences in 2 files in 2 packages.)
FAIL
FAIL	golang.org/x/tools/cmd/gorename	2.226s

[alandonovan]

@suzmue this looks like yours.

[gopherbot]

CL https://golang.org/cl/47231 mentions this issue.

[gopherbot]

CL https://golang.org/cl/47410 mentions this issue.