Skip to content

inlined code has invalid line numbers #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rsc opened this issue Dec 18, 2011 · 1 comment
Closed

inlined code has invalid line numbers #2580

rsc opened this issue Dec 18, 2011 · 1 comment

Comments

@rsc
Copy link
Contributor

rsc commented Dec 18, 2011

inlined code should be assigned the same line
number as the code it is replacing (the same line
number as the call itself).  the argument can be
made that it should have its original line number,
but i've always found that very confusing, we're
inlining small enough pieces that the call is clear,
and it will be easiest on tools that assume that
all the PCs in a function are in a single file.

right now the substituted code appears to have some
other line number entirely, resulting in very strange
source bounds when disassembling code using the
pprof disasm command.
@lvdlvd
Copy link

lvdlvd commented Dec 23, 2011

Comment 1:

Fixed by http://golang.org/cl/5498068/
http://code.google.com/p/go/source/detail?r=8259f4a19e6e

Status changed to Fixed.

@rsc rsc added fixed labels Dec 23, 2011
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants