cmd/go: modules: use of internal package not allowed

[bradfitz]

I just tried using modules at Go tip (b9761b1) with Perkeep (github.com/perkeep/perkeep).

Are these errors expected, @rsc, @bcmills?

$ cd $HOME
$ git clone https://perkeep.googlesource.com/perkeep
$ cd perkeep
$ go mod -init
...
$ go install ./server/perkeepd
...
../../src/mod/github.com/cznic/[email protected]/kv.go:16:2: use of internal package github.com/cznic/internal/buffer not allowed
../../src/mod/github.com/cznic/[email protected]/memfiler.go:13:2: use of internal package github.com/cznic/internal/file not allowed
../../src/mod/github.com/cznic/[email protected]/buffer/buffer.go:36:2: use of internal package github.com/cznic/internal/slice not allowed

/cc @mpl

[bcmills]

Dup of #23970. (github.com/cznic/internal is its own repo, and therefore its own module.)

I'm planning to fix this before the final 1.11 release, but it might not make beta2.

[sneko]

Hi @bcmills, did you fix that in the 1.11 release?

[bcmills]

Yep.

[sneko]

I'm trying to use the Redigo library (for Redis), I'm able to run go mod tidy but when launching some tests with go test I get this error:

\go\src\mod\github.com\garyburd\[email protected]+incompatible\redis\pool.go:28:2: use of internal package github.com/gomodule/redigo/internal not allowed

Maybe it's related to something else than this issue?

[sneko]

@bcmills

According to another repo I use for Redigo (go-redsync/redsync#21), they didn't release anything since 2016. I think that's the origin of my problem.

[bcmills]

github.com/garyburd/redigo is not allowed to access github.com/gomodule/redigo/internal because github.com/gomodule/redigo is not a prefix of github.com/garyburd/redigo: this is working as designed.

If you intend for github.com/garyburd/redigo to replace github.com/gomodule/redigo, you'll need to use a replace directive and import via the latter path.