path/filepath --- FAIL: TestEvalSymlinks

[gopherbot]

by blake.mizerany:

$ uname -a
Darwin shake.heroku.com 11.2.0 Darwin Kernel Version 11.2.0: Tue Aug  9 20:54:00 PDT
2011; root:xnu-1699.24.8~1/RELEASE_X86_64 x86_64

$ go version
go version weekly.2012-01-20 11475

$ pwd
/Users/blake/src/go

$ go test std -short
...
FAIL    path/filepath   0.031s
--- FAIL: TestEvalSymlinks (0.00 seconds)
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/dir") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/link1") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/link2") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/link1/dir") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/dir/link3") error: lstat src: no such file or directory
    path_test.go:580: EvalSymlinks("src/pkg/path/filepath/test/link2/link3/test") error: lstat src: no such file or directory
panic: interface conversion: interface is nil, not *os.FileStat

goroutine 16 [running]:
path/filepath_test.TestAbs(0x421854d0, 0x2d69d2f0)
    /Users/blake/src/go/src/pkg/path/filepath/path_test.go:667 +0x664
testing.tRunner(0x421854d0, 0x160028, 0x0, 0x0)
    /Users/blake/src/go/src/pkg/testing/testing.go:254 +0x6f
created by testing.RunTests
    /Users/blake/src/go/src/pkg/testing/testing.go:329 +0x76e

goroutine 1 [runnable]:
testing.RunTests(0x2000, 0x15fed8, 0x1100000011, 0x0, 0x159ee0, ...)
    /Users/blake/src/go/src/pkg/testing/testing.go:330 +0x791
testing.Main(0x2000, 0x15fed8, 0x1100000011, 0x169d88, 0x0, ...)
    /Users/blake/src/go/src/pkg/testing/testing.go:265 +0x62
main.main()
    /var/folders/d6/lg_c4tf52gs468hj6v3n54b40000gn/T/go-build612435191/path/filepath/_test/_testmain.go:75 +0x91
...

[robpike]

Comment 1:

The crash is a bug in the test. It's not clear what you're reporting here. Are there two
issues, failures and crashes?

[robpike]

Comment 2:

Labels changed: added priority-go1, removed priority-triage.

Status changed to Accepted.

[bradfitz]

Comment 3:

This was the output Blake got when he was running all the tests after making some
database/sql changes.
I saw the output and was said, "That's not your fault, but file a bug... that shouldn't
happen."
So http://code.google.com/p/go/source/detail?r=2b2b2f24c makes the failure prettier, but
it's not clear why the test failed for him in the first place.  (on OS X Lion)

[rsc]

Comment 4:

This test is running mkdir test in the current directory
and assuming that directory is src/pkg/path/filepath.
That's not true.  Why isn't it always failing?
Also, this is bogus:
    goroot, err := filepath.EvalSymlinks(os.Getenv("GOROOT"))
    if err != nil {
        t.Fatalf("EvalSymlinks(%q) error: %v", os.Getenv("GOROOT"), err)
    }
os.Getenv("GOROOT") can return "" and clearly did in the transcript above.
Very sketchy test.  Should probably just write a new one from scratch.

[rsc]

Comment 5:

Labels changed: added go1-must.

[robpike]

Comment 6:

Owner changed to @robpike.

Status changed to Started.

[robpike]

Comment 7:

This issue was closed by revision 97ef437.

Status changed to Fixed.