-
Notifications
You must be signed in to change notification settings - Fork 18k
.github: hide text for issue author in ISSUE_TEMPLATE #27914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
One possible counter-argument against this is that template text showing up in the submitted issue can be used as a signal for issue report quality. High quality issue reports are less likely to include text that isn't relevant. I would argue that's not a strong reason. It's still possible to tell whether the issue report is high quality and actionable even if that text never shows up, by looking at the content of the issue. |
Change https://golang.org/cl/138295 mentions this issue: |
It's hard to post the diff for that file in this issue, so I sent a do-not-submit CL 138295 with the diff. It's there to augment this issue only, and not meant to be submitted unless we decide doing this is a good idea. |
Using the It's not foolproof, as sometimes people still manage to muck things up... but on the whole this should be a good improvement. 😄 |
I don't have a problem with this. Go for it. |
Sounds good. I'll apply the change just before my next triaging rotation, and make sure it has a positive effect on the new issue reports. |
The current issue template contains some text that is meant for the issue author to read, internalize, and hopefully delete (since it's usually not relevant to the issue).
That text includes:
And:
Some issues that are submitted include answers to all the questions, but they don't delete that text. It can happen either because the author didn't realize they're supposed to delete it, or overlooked it.
The result is that the final issue is valid and actionable, but includes text that is distracting.
I have a potential .github/ISSUE_TEMPLATE change in mind that resolves this issue. It places the author-facing text inside HTML comments, so even if left behind, it will not appear when the issue is rendered.
Additionally, the potential .github/ISSUE_TEMPLATE change makes use of HTML tag to make it so that
go env
by default is collapsed, but can be expanded when needed. I think this is helpful because in most issues, seeing detailedgo env
output isn't something that needs to be done often. We still want the information to be available, and this adjustment tweaks only the default presentation, it doesn't remove it.Screenshots
Before -> After
Expanding the
go env
output element works as expected./cc @bradfitz @ianlancetaylor @katiehockman
The text was updated successfully, but these errors were encountered: