Skip to content

.github: hide text for issue author in ISSUE_TEMPLATE #27914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Sep 27, 2018 · 6 comments
Closed

.github: hide text for issue author in ISSUE_TEMPLATE #27914

dmitshur opened this issue Sep 27, 2018 · 6 comments
Labels
Community FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Member

dmitshur commented Sep 27, 2018

The current issue template contains some text that is meant for the issue author to read, internalize, and hopefully delete (since it's usually not relevant to the issue).

That text includes:

Please answer these questions before submitting your issue. Thanks!

And:

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

Some issues that are submitted include answers to all the questions, but they don't delete that text. It can happen either because the author didn't realize they're supposed to delete it, or overlooked it.

The result is that the final issue is valid and actionable, but includes text that is distracting.

I have a potential .github/ISSUE_TEMPLATE change in mind that resolves this issue. It places the author-facing text inside HTML comments, so even if left behind, it will not appear when the issue is rendered.

Additionally, the potential .github/ISSUE_TEMPLATE change makes use of HTML tag to make it so that go env by default is collapsed, but can be expanded when needed. I think this is helpful because in most issues, seeing detailed go env output isn't something that needs to be done often. We still want the information to be available, and this adjustment tweaks only the default presentation, it doesn't remove it.

Screenshots

Before -> After

Expanding the go env output element works as expected.

/cc @bradfitz @ianlancetaylor @katiehockman

@dmitshur dmitshur added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Community labels Sep 27, 2018
@dmitshur
Copy link
Member Author

One possible counter-argument against this is that template text showing up in the submitted issue can be used as a signal for issue report quality. High quality issue reports are less likely to include text that isn't relevant.

I would argue that's not a strong reason. It's still possible to tell whether the issue report is high quality and actionable even if that text never shows up, by looking at the content of the issue.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/138295 mentions this issue: .github: don't render author-facing text in ISSUE_TEMPLATE

@dmitshur
Copy link
Member Author

It's hard to post the diff for that file in this issue, so I sent a do-not-submit CL 138295 with the diff. It's there to augment this issue only, and not meant to be submitted unless we decide doing this is a good idea.

@justinclift
Copy link

justinclift commented Sep 28, 2018

Using the <!-- --> tags like that is a good idea. We've been doing similar with the DB4S repo for a while now, and for us it's helped.

It's not foolproof, as sometimes people still manage to muck things up... but on the whole this should be a good improvement. 😄

@andybons
Copy link
Member

I don't have a problem with this. Go for it.

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Oct 15, 2018
@andybons andybons added this to the Unreleased milestone Oct 15, 2018
@dmitshur dmitshur self-assigned this Oct 15, 2018
@dmitshur
Copy link
Member Author

Sounds good. I'll apply the change just before my next triaging rotation, and make sure it has a positive effect on the new issue reports.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Community FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants