Skip to content

misc/dist: create a zip file as well as the msi installer #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adg opened this issue Mar 8, 2012 · 6 comments
Closed

misc/dist: create a zip file as well as the msi installer #3254

adg opened this issue Mar 8, 2012 · 6 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone

Comments

@adg
Copy link
Contributor

adg commented Mar 8, 2012

Turns out people like zip files. Who knew?
@adg
Copy link
Contributor Author

adg commented Mar 9, 2012

Comment 1:

The bindist tool now generates them:
http://code.google.com/p/go/source/detail?r=2271b03494fb
Now all that's needed is documentation in install.html

Labels changed: added documentation.

@bradfitz
Copy link
Contributor

bradfitz commented Mar 9, 2012

Comment 2:

And here's a CL which uses archive/zip to generate the zips, rather than 7z:
http://golang.org/cl/5794046/
Untested on Windows, though.

@jpoirier
Copy link
Member

Comment 3:

Doing a quick test on windows > bindist.exe -noauth=true sourcezip
ERROR: Do not use make.bash to build on Windows.
Use make.bat instead.
2012/03/09 18:17:39 sourcezip: bash make.bash --dist-tool: exit status 1
-joe

@bradfitz
Copy link
Contributor

Comment 4:

Joe, don't use "sourcezip" on Windows. I just added that target for debugging the
archive/zip-writing code on Linux.

@jpoirier
Copy link
Member

Comment 5:

It hangs after the zip file is created
C:\go\misc\dist>bindist.exe -noauth=true windows-386
...
2012/03/10 13:59:32 adding "\\go.weekly.2012-03-04.windows-386.zip"
-joe

@adg
Copy link
Contributor Author

adg commented Mar 13, 2012

Comment 6:

This issue was closed by revision cf46040.

Status changed to Fixed.

@adg adg added fixed Documentation Issues describing a change to documentation. labels Mar 13, 2012
@adg adg self-assigned this Mar 13, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

5 participants