-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/gopls: support window/showMessage request #33198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What features are you finding that take 5s? We are working on correcting this behavior, so ultimately it shouldn't be necessary. The only way for |
I'm afraid I'm a bit unintelligent about gopls vis-a-vis separating "it works" into features heh. So, not sure. General use, though, I suppose?
Ah, gotcha. That seems limiting, so maybe this request is not feasible?
Gotcha. Is there a different issue I should track, and close this one? |
We've heard reports of imports taking too long, which is why I ask. I guess we could also make use of the https://microsoft.github.io/language-server-protocol/specification#window_showMessage LSP request, so I guess we could change this issue to be that. |
This issue is really a duplicate of #31668. Closing in favor of that issue. |
Sometimes gopls takes a few seconds to process what's happening. I don't have a concrete example - it just seems to sometimes take 100ms to do something, and other times it takes 5s.
It would be great if gopls would fail fast with an error message that popped up in vscode, and that I could adjust what that threshold should be.
Having fast feedback is almost always more important to me than eventual correctness.
The text was updated successfully, but these errors were encountered: