Skip to content

compile: s390x copysign and abs codegen tests broken #34183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martisch opened this issue Sep 9, 2019 · 1 comment
Closed

compile: s390x copysign and abs codegen tests broken #34183

martisch opened this issue Sep 9, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.14

Comments

@martisch
Copy link
Contributor

martisch commented Sep 9, 2019

CL https://go-review.googlesource.com/c/go/+/191780 preferring AND over shifts broke the s390x codegen math tests.

I assume the copysign and abs detection introduced in CL https://go-review.googlesource.com/c/go/+/73950/ does not apply anymore.

The ssa optimization rules for s390x will need to be adjusted to detect the new patterns.

cc @mundaym @randall77
@martisch martisch self-assigned this Sep 9, 2019
@martisch martisch added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 9, 2019
@martisch martisch added this to the Go1.14 milestone Sep 9, 2019
@martisch
Copy link
Contributor Author

martisch commented Sep 9, 2019

Rolling back in https://go-review.googlesource.com/c/go/+/193850 as it also broke arm64. Will followup on #33826.

@martisch martisch closed this as completed Sep 9, 2019
@golang golang locked and limited conversation to collaborators Sep 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@martisch @gopherbot