cmd/go: incorrectly rejects '@' character in directory names [1.13 backport]

[gopherbot]

@jayconrod requested issue #35115 to be considered for backport to the next 1.13 minor release.

@gopherbot Please backport to go1.13

[jayconrod]

This was a regression in 1.13.3, caused by an earlier cherry-pick. There is a mildly annoying workaround (renaming the workspace directory). However, the fix is straightforward.

[gopherbot]

Change https://golang.org/cl/202763 mentions this issue: [release-branch.go1.13] cmd/go: ignore '@' when cleaning local and absolute file path args

[bcmills]

Do we know of anyone actually affected by this regression? (If not, let's not risk a cherry-pick.)

[jayconrod]

It was reported in microsoft/vscode-go#2858. VSCode and gopls don't use @ in directory names by convention though. Perhaps that person is the only one affected?

So yeah, let's not risk it.

[AlekSi]

So that wasn't really back ported? Can you remove milestone then?

[bcmills]

@AlekSi, by convention only the issues labeled CherryPickApproved are included in point releases. (If we're linking to the wrong search somewhere, we should fix the link; CC @andybons.)

[AlekSi]

You link to the milestone from there: https://golang.org/doc/devel/release.html#go1.13.minor Note that all issues in that milestone do not have that label.

[dmitshur]

Note that all issues in that milestone do not have that label.

That was a bug. It has been fixed now. Sorry for any confusion.

You can use https://github.com/golang/go/issues?q=milestone%3AGo1.13.4+label%3ACherryPickApproved to see the list of backports that went into Go 1.13.4.