Skip to content

x/pkgsite: add second module to testdata for frontend.testServer #39631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
julieqiu opened this issue Jun 17, 2020 · 5 comments
Closed

x/pkgsite: add second module to testdata for frontend.testServer #39631

julieqiu opened this issue Jun 17, 2020 · 5 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

Add a second module to testdata for frontend.testServer, so that we can verify that we are getting the latest version:

https://github.com/golang/pkgsite/blob/a2ecf39/internal/frontend/server_test.go#L570

Related: #39621
@gopherbot gopherbot added this to the Unreleased milestone Jun 17, 2020
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Jun 17, 2020
@AndersonQ
Copy link
Contributor

I can take it :)

@julieqiu
Copy link
Member Author

julieqiu commented Jul 7, 2020

Thank you!

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/241297 mentions this issue: internal/frontend: add check to ensure latest module version is loaded

@AndersonQ
Copy link
Contributor

AndersonQ commented Jul 7, 2020 •
edited
Loading

The current "ordinary" module already has got multiple versions. Then I just added a check to ensure the latest version is the one loaded.
I believe it should cover the issue, right?

@julieqiu
Copy link
Member Author

julieqiu commented Jul 7, 2020

Yup, thanks for the fix! :)

@golang golang locked and limited conversation to collaborators Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@AndersonQ @julieqiu @gopherbot