Skip to content

x/vuln/vulncheck: panic - interface conversion: types.Type is *types.Interface, not *types.Struct #57298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JackMordaunt opened this issue Dec 14, 2022 · 4 comments
Closed

x/vuln/vulncheck: panic - interface conversion: types.Type is *types.Interface, not *types.Struct #57298

JackMordaunt opened this issue Dec 14, 2022 · 4 comments
Assignees
@zpavlinovic
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
vuln/unplanned

Comments

@JackMordaunt
Copy link

JackMordaunt commented Dec 14, 2022 •
edited
Loading

What version of Go are you using (go version)?

go version go1.19.3 linux/amd64

Does this issue reproduce at the latest version of golang.org/x/vuln?

Yes

What did you do?

Run govulncheck ./... on a multi-package proprietary codebase, one that uses cgo.

What did you expect to see?

Successful exit, or even partial vulnerability results.

What did you see instead?

govulncheck is an experimental tool. Share feedback at https://go.dev/s/govulncheck-feedback.

Scanning for dependencies with known vulnerabilities...
panic: interface conversion: types.Type is *types.Interface, not *types.Struct

goroutine 1 [running]:
golang.org/x/tools/go/callgraph/vta.field.Type({{0x958430?, 0xc03fac2bd0?}, 0xc0ab3bd468?})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:108 +0x78
golang.org/x/tools/go/callgraph/vta.(*builder).representative(0xc0ab3bd790, {0x958c28, 0xc0c1042d68})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:692 +0x4a
golang.org/x/tools/go/callgraph/vta.(*builder).addInFlowEdge(0xc0ab3bd790, {0x958c28, 0xc0c1042d68}, {0x958cc8, 0xc0c1056a90})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:653 +0x65
golang.org/x/tools/go/callgraph/vta.(*builder).fieldAddr(0xc0ab3bd790?, 0xc088580600)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:436 +0xca
golang.org/x/tools/go/callgraph/vta.(*builder).instr(0xc0ab3bd678?, {0x95b870?, 0xc088580600?})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:347 +0x2d4
golang.org/x/tools/go/callgraph/vta.(*builder).fun(...)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:299
golang.org/x/tools/go/callgraph/vta.(*builder).visit(0xc0ab3bd790, 0xc000064c00?)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:291 +0x1e5
golang.org/x/tools/go/callgraph/vta.typePropGraph(...)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/graph.go:265
golang.org/x/tools/go/callgraph/vta.CallGraph(0xc0ab3bdb70?, 0xc0d05ac580)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/go/callgraph/vta/vta.go:75 +0xe5
golang.org/x/vuln/vulncheck.callGraph(0xc06963a0c0, {0xc01b539000, 0x581, 0x40?})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/vulncheck/utils.go:71 +0x2b9
golang.org/x/vuln/vulncheck.Source({0x95a2f0, 0xc000130020}, {0xc067e65400?, 0x44, 0x80}, 0xc067dddd78)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/vulncheck/source.go:80 +0x4cd
golang.org/x/vuln/internal/govulncheck.Source({0x95a2f0?, 0xc000130020?}, 0xc000191eb0?, {0xc067e65400, 0x44, 0x80})
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/internal/govulncheck/run.go:31 +0x94
main.doGovulncheck({0xc00012c010?, 0x1, 0x1}, 0x1)
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/cmd/govulncheck/main.go:114 +0x35b
main.main()
        /home/jack/go/pkg/mod/golang.org/x/[email protected]/cmd/govulncheck/main.go:69 +0x127
@JackMordaunt JackMordaunt added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Dec 14, 2022
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Dec 14, 2022
@JackMordaunt
Copy link
Author

Actually, this is strange. I ran govulncheck per package and all invocations are successful. It's only when I use the spread operator that it panics. It would be useful for it to report some diagnostics when panic, like what package it was analyzing while it panicked.

@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 14, 2022
@hyangah
Copy link
Contributor

hyangah commented Dec 14, 2022

What is the version of govulncheck?

go version -m <path_to_govulncheck>

@hyangah hyangah changed the title x/vuln: x/vuln: panic - interface conversion: types.Type is *types.Interface, not *types.Struct Dec 14, 2022
@hyangah hyangah changed the title x/vuln: panic - interface conversion: types.Type is *types.Interface, not *types.Struct x/vuln/vulncheck: panic - interface conversion: types.Type is *types.Interface, not *types.Struct Dec 14, 2022
@zpavlinovic
Copy link
Contributor

Does the issue reproduce with the latest version of govulncheck?

@zpavlinovic zpavlinovic self-assigned this Dec 28, 2022
@zpavlinovic zpavlinovic added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jan 23, 2023
@zpavlinovic
Copy link
Contributor

Solved by #57174.

@golang golang locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zpavlinovic zpavlinovic

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
5 participants
@zpavlinovic @hyangah @JackMordaunt @gopherbot @thanm