Skip to content

x/tools/cmd/fiximports: TestFixImports failures #58010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Jan 26, 2023 · 6 comments
Open

x/tools/cmd/fiximports: TestFixImports failures #58010

gopherbot opened this issue Jan 26, 2023 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 10m0s

syscall.Syscall6(0x1c1, 0x6fb, 0xc0000b8f34, 0x0, 0xc000164240, 0x0, 0x0)
	/tmp/workdir/go/src/syscall/asm_unix_amd64.s:39 +0x5
syscall.wait4(0xc0000b8f38?, 0x40ccc7?, 0x90?, 0x5a5960?)
	/tmp/workdir/go/src/syscall/zsyscall_netbsd_amd64.go:34 +0x4e
syscall.Wait4(0x203000?, 0xc0000b8f6c, 0xc0000b8fe8?, 0x5622c6?)
	/tmp/workdir/go/src/syscall/syscall_bsd.go:144 +0x2b
os.(*Process).wait(0xc0001854d0)
	/tmp/workdir/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/tmp/workdir/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc00048f4a0)
	/tmp/workdir/go/src/os/exec/exec.go:514 +0x54
os/exec.(*Cmd).Run(0x5ac4a7?)
	/tmp/workdir/go/src/os/exec/exec.go:341 +0x39
golang.org/x/tools/cmd/fiximports.list({0xc0000b9340?, 0x1?, 0xc0003e8fc0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:489 +0x1d9
golang.org/x/tools/cmd/fiximports.fiximports({0xc000058840?, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:156 +0xe8
golang.org/x/tools/cmd/fiximports.TestFixImports(0xc0000a4680)
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main_test.go:222 +0x625
testing.tRunner(0xc0000a4680, 0x5ba450)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 26, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"
2023-01-25 23:57 netbsd-amd64-9_3 tools@82707575 go@581603cb x/tools/cmd/fiximports.TestFixImports (log) 
panic: test timed out after 10m0s

syscall.Syscall6(0x1c1, 0x6fb, 0xc0000b8f34, 0x0, 0xc000164240, 0x0, 0x0)
	/tmp/workdir/go/src/syscall/asm_unix_amd64.s:39 +0x5
syscall.wait4(0xc0000b8f38?, 0x40ccc7?, 0x90?, 0x5a5960?)
	/tmp/workdir/go/src/syscall/zsyscall_netbsd_amd64.go:34 +0x4e
syscall.Wait4(0x203000?, 0xc0000b8f6c, 0xc0000b8fe8?, 0x5622c6?)
	/tmp/workdir/go/src/syscall/syscall_bsd.go:144 +0x2b
os.(*Process).wait(0xc0001854d0)
	/tmp/workdir/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/tmp/workdir/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc00048f4a0)
	/tmp/workdir/go/src/os/exec/exec.go:514 +0x54
os/exec.(*Cmd).Run(0x5ac4a7?)
	/tmp/workdir/go/src/os/exec/exec.go:341 +0x39
golang.org/x/tools/cmd/fiximports.list({0xc0000b9340?, 0x1?, 0xc0003e8fc0?})
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:489 +0x1d9
golang.org/x/tools/cmd/fiximports.fiximports({0xc000058840?, 0x1, 0x1})
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:156 +0xe8
golang.org/x/tools/cmd/fiximports.TestFixImports(0xc0000a4680)
	/tmp/workdir/gopath/src/golang.org/x/tools/cmd/fiximports/main_test.go:222 +0x625
testing.tRunner(0xc0000a4680, 0x5ba450)

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 26, 2023

Duplicate of #57999

@bcmills bcmills marked this as a duplicate of #57999 Jan 26, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"
2023-02-02 23:42 solaris-amd64-oraclerel tools@81111180 go@2f2c5e41 x/tools/cmd/fiximports.TestFixImports (log) 
panic: test timed out after 10m0s
running tests:
	TestFixImports (10m0s)

syscall.Wait4(0xc0002baae0?, 0xc0000a42b0?, 0x0?, 0x0?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/syscall/syscall_solaris.go:275 +0x26
os.(*Process).wait(0xc0000b1260)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc00012cb00)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0x5befa2?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:590 +0x2d
golang.org/x/tools/cmd/fiximports.list({0xc0001b5340?, 0x1?, 0xc0002b8ee0?})
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:489 +0x1d1
golang.org/x/tools/cmd/fiximports.fiximports({0xc0002181a0?, 0x1, 0x1})
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/fiximports/main.go:156 +0xcc
golang.org/x/tools/cmd/fiximports.TestFixImports(0xc000082680)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/fiximports/main_test.go:222 +0x625
testing.tRunner(0xc000082680, 0x5ce4e8)

— watchflakes

@gopherbot gopherbot reopened this Feb 3, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"
2024-07-29 22:04 x_tools-go1.22-plan9-arm tools@55d718e5 release-branch.go1.22@8c8adffd x/tools/cmd/fiximports.TestFixImports [ABORT] (log) 
=== RUN   TestFixImports
*** Test killed with quit: ran too long (11m0s).
signal: killed
2024-07-29 22:04 x_tools-gotip-plan9-arm tools@55d718e5 go@8246171b x/tools/cmd/fiximports.TestFixImports [ABORT] (log) 
=== RUN   TestFixImports
*** Test killed with quit: ran too long (11m0s).
signal: killed
2024-07-31 20:28 x_tools-go1.23-plan9-arm tools@ead76ab5 release-branch.go1.23@c9940fe2 x/tools/cmd/fiximports.TestFixImports [ABORT] (log) 
=== RUN   TestFixImports
*** Test killed with quit: ran too long (11m0s).
signal: killed
2024-07-31 20:28 x_tools-gotip-plan9-arm tools@ead76ab5 go@650abbc0 x/tools/cmd/fiximports.TestFixImports [ABORT] (log) 
=== RUN   TestFixImports
*** Test killed with quit: ran too long (11m0s).
signal: killed

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"
2025-04-07 19:32 x_tools-gotip-windows-386 tools@e73cd5af go@d584d2b3 x/tools/cmd/fiximports.TestFixImports (log) 
=== RUN   TestFixImports
    main_test.go:230: #2. stderr: got <<
        go: error obtaining buildID for go tool link: fork/exec C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_386\link.exe: The parameter is incorrect.
        importfix: exit status 1
        >>, want <<
        testdata\src\old.com\bad\bad.go:2:43: expected 'package', found 'EOF'
        fruit.io/banana
        	testdata\src\fruit.io\banana\banana.go:6: import "titanic.biz/foo"
        	fixed: old.com/one -> new.com/one
        	fixed: titanic.biz/bar -> new.com/bar
        	ERROR: titanic.biz/foo has no import comment
        	imported directly by:
        		fruit.io/pear
        	imported indirectly by:
        		fruit.io/orange
        >>
    main_test.go:243: #2. rewrite[$GOPATH/src/fruit.io/banana/banana.go] missing, want <<package banana
        
        import (
        	_ "new.com/bar"
        	_ "new.com/one"
        	_ "titanic.biz/foo"
        )>>
--- FAIL: TestFixImports (23.02s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/fiximports" && test == "TestFixImports"
2025-04-08 01:33 x_tools-go1.23-windows-arm64 tools@456962ef release-branch.go1.23@7a2cfb70 x/tools/cmd/fiximports.TestFixImports (log) 
=== RUN   TestFixImports
    main_test.go:222: #0. fiximports() = false
    main_test.go:230: #0. stderr: got <<
        runtime: VirtualAlloc of 49152 bytes failed with errno=1455
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff60ee4092a?, 0x40004f0000?})
        	runtime/panic.go:1073 +0x38 fp=0xfa929ff8d0 sp=0xfa929ff8a0 pc=0x7ff60e830008
        runtime.sysUsedOS(0x40004f0000, 0xc000)
...
        	fixed: titanic.biz/bar -> new.com/bar
        >>
    main_test.go:243: #0. rewrite[$GOPATH/src/fruit.io/banana/banana.go] missing, want <<package banana
        
        import (
        	_ "new.com/bar"
        	_ "new.com/one"
        	_ "titanic.biz/foo"
        )>>
--- FAIL: TestFixImports (34.56s)

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot