x/tools/gopls/internal/lsp/cmd/test: TestImports failures

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestImports (6.86s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 66, want 0 (gopls imports -diff a.go: exit=66 stdout=<<--- ./a.go.orig
        +++ ./a.go
        @@ -1,4 +1,6 @@
         package a
        +
        +import "fmt"
         func _() {
         	fmt.Println()
         }
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 1 data race(s)
        >>)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"

2023-01-30 20:48 freebsd-amd64-race tools@d1e92d6a go@01a5a83c x/tools/gopls/internal/lsp/cmd/test.TestImports (log)

--- FAIL: TestImports (6.86s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 66, want 0 (gopls imports -diff a.go: exit=66 stdout=<<--- ./a.go.orig
        +++ ./a.go
        @@ -1,4 +1,6 @@
         package a
        +
        +import "fmt"
         func _() {
         	fmt.Println()
         }
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 1 data race(s)
        >>)

— watchflakes

[bcmills]

Duplicate of #58151

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"

2023-03-15 19:02 darwin-amd64-12_0 tools@e5f7ae13 go@c69ff3a7 x/tools/gopls/internal/lsp/cmd/test.TestImports (log)

--- FAIL: TestImports (39.53s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 1, want success: true (gopls imports -diff a.go: exit=1 stdout=<<>> stderr=<<2023/03/15 23:25:24 internal error decoding *[]cache.gobDiagnostic: EOF
        >>)
    integration_test.go:403: gopls imports -diff a.go: stdout does not match [\+import "fmt"]; got <<>>
    integration_test.go:408: gopls imports -write a.go: exited with code 1, want success: true (gopls imports -write a.go: exit=1 stdout=<<>> stderr=<<2023/03/15 23:25:28 internal error decoding *[]cache.gobDiagnostic: EOF
        >>)

— watchflakes

[adonovan]

The latest flake looks like a dup of #59289 (the test failed because stderr included an unexpected log message reporting a failure of gob decoding). It's a little sad that such a serious error was only detected this way, but I'm going to close this issue.

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"

2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@15c12762 x/tools/gopls/internal/lsp/cmd/test.TestImports (log)

panic: test timed out after 10m0s
running tests:
	TestImports (10m0s)
	TestLinks (10m0s)

syscall.Wait4(0xc0002e8090?, 0xc000312380?, 0x0?, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/syscall/syscall_solaris.go:275 +0x26
os.(*Process).wait(0xc000198030)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc000394000)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0xc0003a61a0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:590 +0x2d
golang.org/x/tools/gopls/internal/lsp/cmd/test.gopls(0xc000461520, {0xc000390be0, 0x49}, {0xc00006bf10, 0x2, 0x2})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:812 +0x325
golang.org/x/tools/gopls/internal/lsp/cmd/test.TestImports(0xc000461520)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:393 +0x125
testing.tRunner(0xc000461520, 0x1032b58)

— watchflakes

[findleyr]

Hung in a syscall, which is a different issue.