Skip to content

x/tools/gopls/internal/lsp/cmd/test: TestImplementations failures #59105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 18, 2023 · 6 comments
Closed

x/tools/gopls/internal/lsp/cmd/test: TestImplementations failures #59105

gopherbot opened this issue Mar 18, 2023 · 6 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImplementations"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestImplementations (30.60s)
    integration_test.go:356: gopls implementation a.go:4:10: exited with code 2, want success: true (gopls implementation a.go:4:10: exit=2 stdout=<</tmp/buildlet/go/src/fmt/print.go:64:2-8
        /tmp/buildlet/go/src/runtime/error.go:208:2-8
        >> stderr=<<panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:359: invalid export data for "runtime": cannot import "runtime" (no packages found for runtime), possibly version skew - reinstall package

        goroutine 5189 [running]:
        golang.org/x/tools/internal/bug.report({0xc000360b40, 0x85}, 0x0)
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/bug/bug.go:75 +0x468
        golang.org/x/tools/internal/bug.Errorf({0x1b3dcdd?, 0x7?}, {0xc00bfdfc28?, 0x1000001d90570?, 0x0?})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/bug/bug.go:56 +0x3f
        golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).importPackage(0xc004fb5c80, {0xc00a36fb90?, 0xc00021ecc0?}, 0xc000196780, {0xc000fda008, 0x1dbb, 0x24f8})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:359 +0x27e
        golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).processPackage(0xc004fb5c80, {0x1d90570, 0xc00a174500}, 0xc001154000)
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:324 +0x412
        golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).TypeCheck.func1.1({0x1d90570?, 0xc00a174500?}, {0x23749a0?, 0xc001727e70?})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:169 +0x46
        golang.org/x/tools/internal/memoize.(*Promise).run.func2.1()
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:187 +0xa9
        runtime/trace.WithRegion({0x1d90570?, 0xc00a174500?}, {0xc00041be60, 0x1a}, 0xc001727f90)
        	/tmp/buildlet/go/src/runtime/trace/annotation.go:141 +0xe3
        golang.org/x/tools/internal/memoize.(*Promise).run.func2()
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:180 +0x145
        created by golang.org/x/tools/internal/memoize.(*Promise).run
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:179 +0x1ea
        >>)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 18, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImplementations"
2023-03-16 15:43 darwin-amd64-nocgo tools@6e5f4255 go@fa42da15 x/tools/gopls/internal/lsp/cmd/test.TestImplementations (log) 
--- FAIL: TestImplementations (30.60s)
    integration_test.go:356: gopls implementation a.go:4:10: exited with code 2, want success: true (gopls implementation a.go:4:10: exit=2 stdout=<</tmp/buildlet/go/src/fmt/print.go:64:2-8
        /tmp/buildlet/go/src/runtime/error.go:208:2-8
        >> stderr=<<panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:359: invalid export data for "runtime": cannot import "runtime" (no packages found for runtime), possibly version skew - reinstall package

        goroutine 5189 [running]:
        golang.org/x/tools/internal/bug.report({0xc000360b40, 0x85}, 0x0)
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/bug/bug.go:75 +0x468
        golang.org/x/tools/internal/bug.Errorf({0x1b3dcdd?, 0x7?}, {0xc00bfdfc28?, 0x1000001d90570?, 0x0?})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/bug/bug.go:56 +0x3f
        golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).importPackage(0xc004fb5c80, {0xc00a36fb90?, 0xc00021ecc0?}, 0xc000196780, {0xc000fda008, 0x1dbb, 0x24f8})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:359 +0x27e
        golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).processPackage(0xc004fb5c80, {0x1d90570, 0xc00a174500}, 0xc001154000)
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:324 +0x412
        golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).TypeCheck.func1.1({0x1d90570?, 0xc00a174500?}, {0x23749a0?, 0xc001727e70?})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:169 +0x46
        golang.org/x/tools/internal/memoize.(*Promise).run.func2.1()
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:187 +0xa9
        runtime/trace.WithRegion({0x1d90570?, 0xc00a174500?}, {0xc00041be60, 0x1a}, 0xc001727f90)
        	/tmp/buildlet/go/src/runtime/trace/annotation.go:141 +0xe3
        golang.org/x/tools/internal/memoize.(*Promise).run.func2()
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:180 +0x145
        created by golang.org/x/tools/internal/memoize.(*Promise).run
        	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:179 +0x1ea
        >>)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 18, 2023
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2023
@findleyr
Copy link
Member

This one is concerning. We should disable the importer panic recovery for testing.

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.0 Mar 18, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/477456 mentions this issue: internal/gcimporter: enable debug mode for tests

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImplementations"
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@ecf7e00d x/tools/gopls/internal/lsp/cmd/test.TestImplementations (log) 
panic: test timed out after 10m0s
running tests:
	TestImplementations (4m41s)
	TestImports (10m0s)

syscall.Wait4(0xc0003fa408?, 0xc000430050?, 0x0?, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/syscall/syscall_solaris.go:275 +0x2c
os.(*Process).wait(0xc00023a000)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec_unix.go:43 +0x85
os.(*Process).Wait(...)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc0001182c0)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0xc000458000?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:590 +0x39
golang.org/x/tools/gopls/internal/lsp/cmd/test.gopls(0xc00042e820, {0xc00042a840, 0x51}, {0xc00006df40, 0x2, 0x2})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:812 +0x347
golang.org/x/tools/gopls/internal/lsp/cmd/test.TestImplementations(0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:355 +0x10a
testing.tRunner(0xc00042e820, 0x1088d10)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImplementations"
2023-04-28 17:21 darwin-amd64-12_0 tools@ab24b7b9 go@972774c4 x/tools/gopls/internal/lsp/cmd/test.TestImplementations (log) 
--- FAIL: TestImplementations (9.06s)
    integration_test.go:356: gopls implementation a.go:4:10: exited with code 2, want success: true (gopls implementation a.go:4:10: exit=2 stdout=<<>> stderr=<<panic: /tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/filecache/filecache.go:82: internal error in filecache.Get("export", b6848efb9e78cf82f9b6fd37facbdf4672d0d20d8fcc1ff4ae2538536361cc6e): invalid checksum at end of 3524-byte file /Users/gopher/Library/Caches/gopls/3f560ddb/export/b6/b6848efb9e78cf82f9b6fd37facbdf4672d0d20d8fcc1ff4ae2538536361cc6e:
        "\xb8\r\x00\x00\x00\x00\x00\x00\x02\xcd\a\xda\x02\x03\x00\x84\x02\x8d\x02\xdf\x0f\x04Kind\x00\x06String\x01k\x05slice\x01i\x01j\fAssignableTo\x01u\x04Type\nComparable\x04Elem\nImplements\x04Name\aPkgPath\x04Size\x06common\x05rtype\buncommon\funcommonType\x03typ\x03ptr\x04flag\apointer\x01v\x05Value\x06CanSet\x05IsNil\aIsValid\x03Len\tnumMethod\x03Set\x01x\bassignTo\acontext\x03dst\x06target\x06Method\x05Error\x01e\nValueError\x04size\aptrdata\x04hash\x05tflag\x05align\nfieldAlign\x04kind\x05equal\x06gcdata\x03str\anameOff\tptrToThis\atypeOff\x01t\x03off\x04name\bpointers\x0fexportedMethods\x06method\tNumMethod\ahasName\achanDir\x02In\x03Key\bNumField\x05NumIn\x06NumOut\x03Out\apkgPath\x06mcount\x06xcount\x04moff\x01_\amethods\x01f\x02ro\x0emustBeExported\x10mustBeAssignable\x05bytes\x04data\x01n\awhySafe\nisExported\x06hasTag\bembedded\nreadVarint\x03tag\x04mtyp\x03ifn\atextOff\x03tfn1/tmp/buildlet/go/src/internal/reflectlite/type.go4/tmp/buildlet/go/src/internal/reflectlite/swapper.go2/tmp/buildlet/go/src/internal/reflectlite/value.go\vreflectlite\x05Array\x04Bool\x04Chan\nComplex128\tComplex64\aFloat32\aFloat64\x04Func\x03Int\x05Int16\x05Int32\x05Int64\x04Int8\tInterface\aInvalid\x03Map\aPointer\x03Ptr\x05Slice\x06Struct\aSwapper\x06TypeOf\x04Uint\x06Uint16\x06Uint32\x06Uint64\x05Uint8\aUintptr\rUnsafePointer\aValueOf\xd6\x04\x81\xc3\x01\xce\al\x15\xbc\x06\x05\xc3\x01\a\xdb\x02\x04\x89\x01\x03B\x03W\x03h\x03_\a\xa9\x02\x04g\x02\x0e\x01\x11\v\xe1\x02\x03\x18\x01\x15\x01\x06\x01\x05\x01\x06\x01\a\x01\a\x01\a\x01\x06\x01\a\x01\b\x01\b\x01\b\x01\t\x01\t\x01\t\x01\v\x01\f\x01\a\x01\x06\x01\x06\x01\v\x01\x05\x01\t\x01\a\x01\b\x01\b\x03\x12\n\xbc\x02\"\x99\b\x01\x14\x01\x14\x01M\x01G\x014\x01<\x01@\x03\x87\x01\x015\x01.\x01\"\x04d\x01\x15\x01 \x010\x01?\a\xbc\x02\x01\x1b\x01K\x01&\x01/\x01D\x04Px\xd9\x17\x01\x13\x03\x10\x04|\x04D\x04@\x06\xc0\x01\v\xbf\x01\b\x98\x01\t\xbd\x01\x1e\xf9\x06%\xc7\x06\a\xbb\x01\x11\xb3\x05\x01'\x01*\x027\x04t\x04q:\xdd\a\b\x81\x01\x022\x02@\x02;\x02.\b\x81\x01\b\xa9\x01\v\xab\x01\x04D\x13\x8f\x02\b\xac\x01\x15\xdb\x03\b\xa7\x01\b\x9d\x01\b\x9f\x01\b\xaf\x01\b\xa4\x01\b\xa4\x01/\x80\f\x05h\n\xf8\x01\b\xc3\x01\x88\x05\xec\x0fN\x01\x10\x86\x03\xbd\x05\xfdk\xdd\x03\x19\"\xe5\t\x02P\x04\x91\x01\x0e\xb8\x05\t\xaf\x02\x0e\xe4\x02\x04>\t\xcf\x01A\x9b\x0e\x01\x19\x01\x0f\x03\x10\x1a\x9a\x05\f\xf6\x02\x12\xf3\x04\b\x8b\x02?\xcb\f\x19\xa0\x06\x06\x9a\x01\n\xed\x01\x15\xb7\x04\n\x8f\x02\x10\xf3\x02\x12\x8a\x03\x11\xfe\x03\x00\x00\x05C\x01\xfe\x15 \x06\x11C\x01\x81\x15 \x06\x01C\x01\x85\x16 \x06\x12C\x01\xf2\x15 \x06\x10C\x01\xe7\x15 \x06\x0fC\x01\xd5\x15 \x06\rC\x01\xde\x15 \x06\x0eC\x01\x8b\x16 \x06\x13C\x01\x87\x15 \x06\x02C\x01\x92\x15 \x06\x04C\x01\x99\x15 \x06\x05C\x01\xa0\x15 \x06\x06C\x01\x8c\x15 \x06\x03C\x01\x91\x16 \x06\x14C\x01\xec\x14 \x06\x00T\x01\xd8\x14\x06\x01\x01\x89T\x06\x01\x81T\r \x00\x01\x01\x92T\x05\x10C\x01\x9c\x16 \x06\x15C\x01\xa1\x16 \x06\x16C\x01\xd8\x16 \x06\x16C\x01\xaa\x16 \x06\x17C\x01\xb1\x16 \x06\x18C\x01\xb9\x16 \x06\x19\x06\x05\x02\x02\xa3\x03\x15\x01\x02\xa6\x03\x17\x01\x00\x00F\x02\x8b\x03\x01\x02\x93\x03\x0f\x1f\x01\x02\x9e\x03\x05\xcc\x01\x00\x00(\x05\x00a\x05\x01\xf0\x01\x00p\x05\x01\xf6\x01\b\x05\x00\v\x01\xe5\r\x19\x01\x01\xf2\r&\xed\x01\x01\x01\xfa\r\x05\x00\x00\x01\xc4\x0e-\x00\x01\x01\xd1\x0e\x05\x00\x01\xd4\x118\x00\x01\x01\xdb\x11\x05\xed\x01\x01\xfd\f=\x01\x01\x88\r&\xed\x01\x01\x01\x90\r\x05\x00\x00\x01\xa6\f\x00\x00\x01\x01\xad\f\x05 \x01\x80\bH\x00\x01\x01\x87\b\x05\x10\x01\xdb\nM\x00\x01\x01\xe5\n\x05\x10\x01\xe4\vU\x00\x01\x01\xeb\v\x05\v\x01\xed\x10\x06\x00\x01\x01\xf6\x10\x05\x10\x01\xe2\x11Z\x00\x01\x01\xeb\x11\x05\xf3\x01\x01\xf3\x11g\x00\x01\x01\xfe\x11\x05\xf9\x01T\x01\xc1\x06\xfc\x01F\x01\xe4\x8d\x01\x01\x01\xeb\x8d\x01\x15\x1f\x01\x01\xf2\x8d\x01\x05\xed\x01\x00C\x01\xa7\x15 \x06\aC\x01\xb4\x15 \x06\tC\x01\xbc\x15 \x06\nC\x01\xc4\x15 \x06\vC\x01\xad\x15 \x06\bC\x01\xcc\x15 \x06\fC\x01\xc1\x16 \x06\x1a\x01\xf0\x01\x00\x85\x01\x05\a\x05\x03\x03\xb6\n}\xd6\x03\x00\x05\x03\xc7\v\x81\x01\x1b\x00\x05\x03\xff\x10\x85\x01\xd9\x03\x01\x05\x00\x94\x01\x05\x01\xf0\x01T\x03\xea\t\xdd\x03\v\x03\xad\x18\x8a\x01\x03\xa4\x18\x92\x01\xf9\x03\x00\x01\x03\xb7\x18\x05\x1b\x03\x834\x9a\x01\x03\xfa3\x92\x01\xf9\x03\x00\x01\x03\x8c4\x05\x00\x03\x8e68\x03\x856\x92\x01\xf9\x03\x00\x01\x03\x956\x05\xf9\x03\x03\xd9B\xa1\x01\x03\xd0B\x92\x01\xf9\x03\x00\x01\x03\xe1B\x05\x00\x03\xf9H\xa7\x01\x03\xf0H\x92\x01\xf9\x03\x00\x01\x03\x83I\x05\x00\x03\x93J\x00\x03\x8aJ\x92\x01\xf9\x03\x00\x01\x03\x9aJ\x05 \x03\x80L\xaf\x01\x03\xf7K\x92\x01\xf9\x03\x00\x01\x03\x86L\x05\x01\x03\xb7P\xb3\x01\x03\xaeP\x92\x01\xf9\x03\x00\x01\x03\xc3P\x05\x01\x03\xc6R\xbd\x01\x03\xbdR\x92\x01\xf9\x03\x01\x03\xcaR\xc1\x01\xf9\x03\x00\x00\x03\xb9U(\x03\xb0U\x92\x01\xf9\x03\x00\x01\x03\xc0U\x05\xed\x01\x03\xc1\\\xc3\x01\x03\xb8\\\x92\x01\xf9\x03\x03\x03\xca\\\xcc\x01\x10\x03\xda\\\xd4\x01\xfd\x03\x03\xe6\\\xd8\x01\x1b\x01\x03\xfd\\\x05\xf9\x03\x00\a\x05\x02\x03\xd3&\xdf\x01\x10\x00\x05\x03\xe2&\x00 \x00\x05\x00\xee\x01\x05\x01\x81\x06T\x03\xbe&\xef\x05\x01\x03\x86'\xe6\x01\x03\xf7&\xec\x01\x85\x06\x00\x01\x03\x8e'\x05\x10F\x03\xb9X\x01\x03\xc1X\x15\x1f\x01\x03\xc8X\x05\xf9\x03\x00\x00\x8b\x02\x05\x06\x05\x02\x01\xaa%\x05\x1b\x01\xba%\x05\x1b\x01\x01\xca%\x05\x00\x00\x01\x11\x00\xb8\x02\x05\x00\xca\x02\x05\a\x05\v\x01\xbc!\xf9\x01\v\x00\x05\x01\xd0!\xfe\x01\v\x00\x05\x01\x9d\"\x86\x02\t\x00\x05\x01\xe4\"\x8b\x02\xb4\x06\x00\x05\x01\x98#\x91\x02\a\x00\x05\x01\xd4#\x97\x02\a\x00\x05\x01\x94$\xa2\x02\a\x00\x05\x01\x9b%\xa7\x02\xb8\x06\x00\x05\x01\xd0%\xad\x02\xcc\x06\x00\x05\x01\xfe%\xb4\x02\xce\x06\x00\x05\x01\xa0&\xc0\x02\xd2\x06\x00\x05\x01\xf0\x01\x00\xd8\x02\x05\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf6\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x00\xf6\x02\x05\x02\xde\a\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x00\x8f\x03\x05\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01\x01\xf0\x01T\x01\xac!\xd6\x06\x19\x01\xc8b\xb8\x02\x01\xbeb\xd2\x02\xb6\a\x01\x01\xd0b\xd4\x02\xce\x06\x01\x01\xddb\x05\xb9\a\x00\x01\xbcc\xca\x02\x01\xb2c\xd2\x02\xbd\a\x01\x01\xc4c\xd4\x02\xd2\x06\x01\x01\xd1c\x05\xc0\a\x00\x01\xaddg\x01\xa3d\xd2\x02\xc3\a\x00\x01\x01\xb8d\x05\xc6\a\x01\x8al\x06\x01\x80l\xd2\x02\xc9\a\x00\x01\x01\x93l\x05\x10\x01\x8bmU\x01\x81m\xd2\x02\xcc\a\x00\x01\x01\x92m\x05\v\x01\xbdm\x00\x01\xb3m\xd2\x02\xcf\a\x00\x01\x01\xc4m\x05 \x01\xfdm\xdd\x02\x01\xf3m\xd2\x02\xd2\a\x00\x01\x01\x88n\x05\x00\x01\xb8nZ\x01\xaen\xd2\x02\xd5\a\x00\x01\x01\xc1n\x05\xd8\a\x01\xe6n\xe6\x02\x01\xdcn\xd2\x02\xdb\a\x00\x01\x01\xf8n\x05\xe2\a\x01\xe7o\xfd\x02\x01\xddo\xd2\x02\xe5\a\x00\x01\x01\xf3o\x05\x01\x01\x90qM\x01\x86q\xd2\x02\xe8\a\x00\x01\x01\x9aq\x05\x10\x01\xbbr\x87\x03\x01\xb1r\xd2\x02\xeb\a\x00\x01\x01\xc5r\x05\x00\x01\xffrH\x01\xf5r\xd2\x02\xee\a\x00\x01\x01\x86s\x05\x10\x01\x8eu\x8f\x03\x01\x84u\xd2\x02\xf1\a\x00\x01\x01\x98u\x05\xf4\a\x01\xbav8\x01\xb0v\xd2\x02\xf8\a\x00\x01\x01\xc1v\x05\xed\x01\x01\x95z\x97\x03\x01\x8bz\xd2\x02\xfb\a\x01\x01\x98z\x15\x01\x01\x01\x9fz\x05\xed\x01\x00\x01\xbc{\x9a\x03\x01\xb2{\xd2\x02\xfe\a\x00\x01\x01\xc2{\x05\xed\x01\x01\xd9|\xaf\x01\x01\xcf|\xd2\x02\x81\b\x00\x01\x01\xdf|\x05\x01\x01\xf8}\x9e\x03\x01\xee}\xd2\x02\x84\b\x00\x01\x01\x83~\x05\x01\x01\xa7\x7f\xa7\x03\x01\x9d\x7f\xd2\x02\x87\b\x00\x01\x01\xaf\x7f\x05\x01\x01ˀ\x01\xad\x03\x01\xc1\x80\x01\xd2\x02\x8a\b\x00\x01\x01Ԁ\x01\x05\x01\x01\xef\x81\x01\xb4\x03\x01\xe5\x81\x01\xd2\x02\x8d\b\x01\x01\xf3\x81\x01\x15\x01\x01\x01\xfa\x81\x01\x05\xed\x01\x00\x01\u05ce\x01=\x01͎\x01\xd2\x02\x90\b\x01\x01\xe2\x8e\x01&\xed\x01\x01\x01\xea\x8e\x01\x05\x00\x00\x01ϐ\x01\x19\x01Ő\x01\xd2\x02\x93\b\x01\x01ܐ\x01&\xed\x01\x01\x01\xe4\x90\x01\x05\x00\x00\x01\x92\x92\x01-\x01\x88\x92\x01\xd2\x02\x96\b\x00\x01\x01\x9f\x92\x01\x05\x00\a\x05\x05\x01\xff*\xb8\x03\xce\x06\x00\x05\x01\xca+\xc0\x03\b\x00\x05\x01\xf0+\xc7\x03\b\x00\x05\x01\x9f,\xce\x03\t\x00\x05\x01\xe3,\xd3\x03\t\x00\x05\x01\xf6\x01\x02\xde\a\x01\xf6\x01\x02\xde\aT\x01\xe8*\xb6\f\x02\x01\xd9Z\xd5\x03\x01\xc8Z\xd2\x02\xe2\f\x00\x01\x01\xe3Z\x05\xe5\f\x01\x94\\\xe6\x02\x01\x83\\\xd2\x02\xe8\f\x00\x01\x01\xa6\\\x05\xeb\fT\x03\xb2\x13\v\x04\x03\x9f\x16\xa2\x02\x03\x97\x16\xdd\x03\xd9\x03\x00\x01\x03\xa6\x16\x05 \x03\xdd\x16\xdf\x03\x03\xd5\x16\xdd\x03\xd9\x03\x00\x01\x03\xe2\x16\x05\xd9\x03\x03\x99,\xe2\x03\x03\x91,\xdd\x03\xd9\x03\x00\x00\x03\x8f/\xf1\x03\x03\x87/\xdd\x03\xd9\x03\x00\x00T\x01\x93\x19\a\x00T\x01\xb5a\x04\x00T\x01\xdca\x04\x00\x01\x11\a\x05\x01\x01\x9fE\x82\x04\xf8\r\x00\x05\x01\x11T\x01\x90E\xfa\r\b\x01\xbcE\x88\x04\x01\xb4E\x8d\x04\xb9\a\x02\x01\xc1E\xd4\x02\x01\x01\xcaE\x8f\x04\x10\x01\x01\xdaE\x05\x86\x0e\x00\x01\xb8F\x97\x04\x01\xb0F\x8d\x04\xb9\a\x00\x01\x01\xc5F\x05\x00\x01\xfcF\xa2\x04\x01\xf4F\x8d\x04\xb9\a\x00\x01\x01\x85G\x05\x00\x01\xbcG\xa9\x04\x01\xb4G\x8d\x04\xb9\a\x00\x01\x01\xc7G\x05\x00\x01\xfcH\xb2\x04\x01\xf4H\x8d\x04\xb9\a\x01\x01\x87I\xd4\x02\x01\x02\x01\x91I\x05\x01\x01\x96I\x05\x01\x00\x01\xbbJ\xd8\x02\x01\xb3J\x8d\x04\xb9\a\x00\x01\x01\xc2J\x05\x10\x01\xd3K\xbd\x04\x01\xcbK\x8d\x04\xb9\a\x00\x01\x01\xd9K\x05\x10\x01\x90M\xb8\x03\x01\x88M\x8d\x04\xb9\a\x00\x01\x01\x9aM\x05\x10\x00\xca\x04\x05\a\x05\x04\x01\x99'\xd8\x02\xce\x06\x00\x05\x01\xb9'\xc1\x04\xd2\x06\x00\x05\x01\xe9'\xc6\x04\xc1\x0f\x00\x05\x01\xa8(\xd2\x04\xc1\x0f\x00\x05T\x01\x88'\xc5\x0f\x00T\x01\xb7-\x01\x00T\x01\x86b\x04\x00\x01\x05\xf0\x05\x00-\xfc\x05\x03\x82\x06\n\x87\x06\x11\x8c\x06\x18\x97\x06\x1f\xa1\x06&\xa9\x06-\xb1\x064\xb6\x06;\xba\x06B\xc0\x06I\xc6\x06P\xcc\x06W\xd1\x06^\xdb\x06e\x00l\xe3\x06\x82\x01\xe7\x06\x89\x01\xef\x06\x90\x01\xf3\x06\x97\x01\x06\x9e\x01\xf9\x06\xa5\x01\x80\a\xbb\x01(\xea\x02\x88\a\xf0\x02\x8f\a\x85\x03\x94\a\x8c\x03\x9b\a\x93\x03\xa2\a\x9a\x03\xa9\a\xa1\x03\xaf\a\xa8\x03\xb7\a\xaf\x03\x94\x01\xe0\x03\xee\x01\xe8\x05\xc5\a\x82\x06\x8f\x03\xd3\x0f\x85\x01\xfd\f\xf6\x02\xcc\x0f\xd8\x02\xe8\r\xb8\x02\xcc\ra\xf9\a\xca\x04\xd9\x0f\x8b\x02\xc6\r\xca\x02\xd2\rp\xce\f\x00\x00\x00\x00"

        goroutine 793 [running]:
        golang.org/x/tools/gopls/internal/bug.report({0xc000f88a80, 0x2863})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/bug/bug.go:71 +0x434
        golang.org/x/tools/gopls/internal/bug.Errorf({0x100b2d641?, 0xdc4?}, {0xc000ca7db0?, 0x6ecc6163533825ae?, 0x100ac87e2?})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/bug/bug.go:52 +0x35
        golang.org/x/tools/gopls/internal/lsp/filecache.Get({0x100ac87e2, 0x6}, {0xb6, 0x84, 0x8e, 0xfb, 0x9e, 0x78, 0xcf, 0x82, ...})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/filecache/filecache.go:82 +0x2ab
        golang.org/x/tools/gopls/internal/lsp/cache.(*typeCheckBatch).getImportPackage(0xc0003ee820, {0x100d5bdb8, 0xc000e9a900}, {0xc00012eae0, 0x14})
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:456 +0x49b
        golang.org/x/tools/gopls/internal/lsp/cache.(*snapshot).forEachPackageInternal.func1()
        	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/check.go:393 +0x27
        golang.org/x/sync/errgroup.(*Group).Go.func1()
        	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:75 +0x5b
        created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 684
        	/tmp/buildlet/gopath/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:72 +0x96
        >>)
    integration_test.go:359: gopls implementation a.go:4:10: stdout does not match [fmt.print.go:]; got <<>>
    integration_test.go:360: gopls implementation a.go:4:10: stdout does not match [runtime.error.go:]; got <<>>

— watchflakes

@findleyr
Copy link
Member

findleyr commented May 3, 2023

I suspect that the "possible version skew" failure was panic recovery of the panic caused by null bytes in filecache.Get.

Therefore, I believe this is a dupe of #59289.

@findleyr findleyr closed this as completed May 3, 2023
@golang golang locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr