Skip to content

internal/trace/v2: TestTraceStacks failures #64063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue Nov 10, 2023 · 2 comments
Closed

internal/trace/v2: TestTraceStacks failures #64063

gopherbot opened this issue Nov 10, 2023 · 2 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2023

#!watchflakes
post <- pkg == "internal/trace/v2" && test == "TestTraceStacks"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTraceStacks (1.69s)
    --- FAIL: TestTraceStacks/Default (1.69s)
        reader_test.go:65: unexpected error while reading the trace: expected a proc but didn't have one
        trace_test.go:569: found bad trace; dumping to test log...
        trace_test.go:570: Trace Go1.22
            EventBatch gen=1 m=18446744073709551615 time=3595135082 size=6
            Frequency freq=2208169663
            EventBatch gen=1 m=4628 time=3594260550 size=185
            ProcStart dt=25 p=6 p_seq=1
            ProcStop dt=17
...
            String id=215
            	data="runtime.(*scavengerState).park"
            String id=216
            	data="C:/workdir/go/src/runtime/mgcscavenge.go"
            String id=217
            	data="runtime.bgscavenge"
            String id=218
            	data="sync.(*WaitGroup).Wait"
            String id=219
            	data="sync.(*Mutex).Unlock"

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "internal/trace/v2" && test == "TestTraceStacks"
2023-11-10 16:18 windows-amd64-2016 go@abf84221 internal/trace/v2.TestTraceStacks (log)
--- FAIL: TestTraceStacks (1.69s)
    --- FAIL: TestTraceStacks/Default (1.69s)
        reader_test.go:65: unexpected error while reading the trace: expected a proc but didn't have one
        trace_test.go:569: found bad trace; dumping to test log...
        trace_test.go:570: Trace Go1.22
            EventBatch gen=1 m=18446744073709551615 time=3595135082 size=6
            Frequency freq=2208169663
            EventBatch gen=1 m=4628 time=3594260550 size=185
            ProcStart dt=25 p=6 p_seq=1
            ProcStop dt=17
...
            String id=215
            	data="runtime.(*scavengerState).park"
            String id=216
            	data="C:/workdir/go/src/runtime/mgcscavenge.go"
            String id=217
            	data="runtime.bgscavenge"
            String id=218
            	data="sync.(*WaitGroup).Wait"
            String id=219
            	data="sync.(*Mutex).Unlock"

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 10, 2023
@bcmills bcmills added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 13, 2023
@mknyszek mknyszek self-assigned this Nov 15, 2023
@mknyszek mknyszek added this to the Go1.22 milestone Nov 15, 2023
@mknyszek
Copy link
Contributor

This issue is fixed on tip as of the resolution of #64061.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
Archived in project
Development

No branches or pull requests

3 participants