Skip to content

x/build/internal/task: TestPrivXPatch failures #66282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 12, 2024 · 2 comments
Closed

x/build/internal/task: TestPrivXPatch failures #66282

gopherbot opened this issue Mar 12, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/build/internal/task" && test == "TestPrivXPatch"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestPrivXPatch
    tagx_test.go:468: task Wait to Announce: started
    tagx_test.go:468: task Mail announcement: started
    tagx_test.go:468: task Load all repositories: started
    tagx_test.go:468: task Publish change: started
    tagx_test.go:468: task Create single-repo plan: started
    tagx_test.go:468: task Load all repositories: started
    tagx_test.go:490: 2024-03-11 09:33:06.1882937 -0700 PDT m=+1.187250301	task Load all repositories: LOG: Examining repositories [net]
    tagx_test.go:472: task Load all repositories: done: [{net golang.org/x/net []  v1.0.0 }]
    tagx_test.go:468: task Publish change: started
    tagx_test.go:490: 2024-03-11 09:34:23.2065484 -0700 PDT m=+78.205505001	task Publish change: LOG: task failed, will retry (1 of 3): git command failed: exit status 1, stderr Cloning into 'C:\b\s\w\ir\x\t\relui-git-clone-460394268'...
        done.
    tagx_test.go:468: task Publish change: started
    privx_test.go:130: context deadline exceeded
--- FAIL: TestPrivXPatch (77.74s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 12, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/build/internal/task" && test == "TestPrivXPatch"
2024-03-11 16:21 x_build-go1.22-windows-amd64-race build@9a3c313d release-branch.go1.22@db6097f8 x/build/internal/task.TestPrivXPatch (log) 
=== RUN   TestPrivXPatch
    tagx_test.go:468: task Wait to Announce: started
    tagx_test.go:468: task Mail announcement: started
    tagx_test.go:468: task Load all repositories: started
    tagx_test.go:468: task Publish change: started
    tagx_test.go:468: task Create single-repo plan: started
    tagx_test.go:468: task Load all repositories: started
    tagx_test.go:490: 2024-03-11 09:33:06.1882937 -0700 PDT m=+1.187250301	task Load all repositories: LOG: Examining repositories [net]
    tagx_test.go:472: task Load all repositories: done: [{net golang.org/x/net []  v1.0.0 }]
    tagx_test.go:468: task Publish change: started
    tagx_test.go:490: 2024-03-11 09:34:23.2065484 -0700 PDT m=+78.205505001	task Publish change: LOG: task failed, will retry (1 of 3): git command failed: exit status 1, stderr Cloning into 'C:\b\s\w\ir\x\t\relui-git-clone-460394268'...
        done.
    tagx_test.go:468: task Publish change: started
    privx_test.go:130: context deadline exceeded
--- FAIL: TestPrivXPatch (77.74s)

— watchflakes

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 12, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 12, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 16, 2024
@dmitshur dmitshur moved this to Active in Test Flakes May 16, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/585421 mentions this issue: internal/task: delete constant timeouts to deflake tests

@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes May 16, 2024
@golang golang locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot