Skip to content

access: approvers #66611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qiulaidongfeng opened this issue Mar 30, 2024 · 1 comment
Closed

access: approvers #66611

qiulaidongfeng opened this issue Mar 30, 2024 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@qiulaidongfeng
Copy link
Member

Hi,

See https://golang.org/wiki/GerritAccess

I'd like to request "approvers" access.

Because I've already voted CodeReview+1 for the following CL, and I want to vote CodeReview+2 and Auto-Submit:

https://go-review.googlesource.com/c/dl/+/221978
https://go-review.googlesource.com/c/go/+/333990
https://go-review.googlesource.com/c/go/+/452956
https://go-review.googlesource.com/c/website/+/509315
https://go-review.googlesource.com/c/go/+/553157
https://go-review.googlesource.com/c/go/+/552375
https://go-review.googlesource.com/c/go/+/536875
https://go-review.googlesource.com/c/go/+/539135
https://go-review.googlesource.com/c/go/+/541739

After the author resolves the review comments, if there are no further questions, I would like to vote CodeReview+2 and Auto-Submit on the following CL:

https://go-review.googlesource.com/c/go/+/539578
https://go-review.googlesource.com/c/go/+/575275

Gerrit user: https://go-review.googlesource.com/q/author:[email protected]

@seankhliao seankhliao added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 31, 2024
@github-project-automation github-project-automation bot moved this to Incoming in Access Mar 31, 2024
@seankhliao seankhliao added this to the Unreleased milestone Mar 31, 2024
@dmitshur dmitshur moved this from Incoming to Active in Access Apr 5, 2024
@dmitshur dmitshur self-assigned this Apr 5, 2024
@dmitshur
Copy link
Contributor

Hi @qiulaidongfeng, thanks for your interest and contributions to Go.

We considered this request (previously considered in #64255). As documented at https://go.dev/wiki/GerritAccess, Gerrit "approvers" access permits reviewing and submitting CLs across the entire Go project. In order for us to have confidence in being able to grant this access, we look for a deeper history of work that demonstrates careful thought, consideration of trade-offs, and good understanding of project conventions and priorities. We're going to decline this request at this time but can consider it again in the future, after a longer period of time passes.

Thanks again.

@github-project-automation github-project-automation bot moved this from Active to Done in Access Apr 12, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Apr 12, 2024
@golang golang locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Reviewed
Development

No branches or pull requests

4 participants