Skip to content

access: Approving CLs ("approvers") #67015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abner-chenc opened this issue Apr 24, 2024 · 2 comments
Closed

access: Approving CLs ("approvers") #67015

abner-chenc opened this issue Apr 24, 2024 · 2 comments
Assignees
Labels
Access Access request. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@abner-chenc
Copy link
Contributor

Hi,

I'd like to request the "approvers" access (https://go-review.googlesource.com/#/admin/groups/1030,members) for myself.

gerrit account: [email protected]
github account: abner-chenc

I have been part of the @golang/loong64 team for a while and have been maintaining the linux/loong64 port and the builder for this port. I will continue to help maintain this port in the UTC+8 time zone for the foreseeable future.

But some CLs on Loong64 take too long to submit (i.e. https://go-review.googlesource.com/c/go/+/525576, https://go-review.googlesource.com/c/go/+/537335)

See https://go.dev/wiki/GerritAccess

Thanks.

@abner-chenc abner-chenc added this to the Unreleased milestone Apr 24, 2024
@dmitshur dmitshur added this to Access Apr 24, 2024
@github-project-automation github-project-automation bot moved this to Incoming in Access Apr 24, 2024
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Apr 24, 2024
@dmitshur
Copy link
Contributor

dmitshur commented May 9, 2024

Thanks for making an access request. We're tracking it and will update this issue when it's been reviewed.

@dmitshur dmitshur removed their assignment May 9, 2024
@gopherbot gopherbot added the Access Access request. label May 16, 2024
@dmitshur dmitshur moved this from Incoming to Active in Access May 17, 2024
@cagedmantis cagedmantis self-assigned this Jul 9, 2024
@cherrymui
Copy link
Member

cherrymui commented Jul 18, 2024

Hi @abner-chenc ,

Thanks for your contributions to the loong64 port! I've discussed this request with the team, and we agreed to grant you access. I've added you to the approvers group.

Please be familiar with the rules for voting and submitting changes as described at https://go.dev/wiki/GerritAccess#approving-cls-approvers. If you're unsure or have any questions, please don't hesitate to ask us.

Additionally, as described at https://go.dev/wiki/GerritAccess#running-trybots-may-start-trybots, please be sure to at least skim CLs before starting a trybot run.

Thank you again for contributing, your help is greatly appreciated!

@github-project-automation github-project-automation bot moved this from Active to Reviewed in Access Jul 18, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Access Access request. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: Reviewed
Development

No branches or pull requests

5 participants