cmd/go: segfault obtaining buildID for go tool compile

[gopherbot]

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestChangeConfiguration/default
    configuration_test.go:46: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing unknown file modification\" at least 1 time(s)" is met, must have:
        any diagnostics at the first position (5:4) matching `var (FooErr)` in "a/a.go"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/30 17:49:39 Created View (#3)\n\tdirectory...
...
[Trace - 17:49:52.199 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/05/30 17:49:52 go/packages.Load #5\n\tview_id=\"4\"\n\tsnapshot=0\n\tdirectory=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work\n\tquery=[file=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work/a/a.go]\n\tpackages=1\n\tduration=3.175954631s\n"}


[Trace - 17:49:52.228 PM] Received notification '$/progress'.
Params: {"token":"8595116916885539764","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestChangeConfiguration/default"
--- FAIL: TestChangeConfiguration/default (13.76s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestChangeConfiguration/default"

2024-05-30 17:27 x_tools-gotip-openbsd-ppc64 tools@2e977ddd go@e6504ce6 x/tools/gopls/internal/test/integration/misc.TestChangeConfiguration/default (log)

=== RUN   TestChangeConfiguration/default
    configuration_test.go:46: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing unknown file modification\" at least 1 time(s)" is met, must have:
        any diagnostics at the first position (5:4) matching `var (FooErr)` in "a/a.go"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/30 17:49:39 Created View (#3)\n\tdirectory...
...
[Trace - 17:49:52.199 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/05/30 17:49:52 go/packages.Load #5\n\tview_id=\"4\"\n\tsnapshot=0\n\tdirectory=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work\n\tquery=[file=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work/a/a.go]\n\tpackages=1\n\tduration=3.175954631s\n"}


[Trace - 17:49:52.228 PM] Received notification '$/progress'.
Params: {"token":"8595116916885539764","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestChangeConfiguration/default"
--- FAIL: TestChangeConfiguration/default (13.76s)

— watchflakes

[findleyr]

This is a Go command segfault, not a flake:

From the logs: "packages.Load error: err: exit status 1: stderr: go: error obtaining buildID for go tool compile: signal: segmentation fault (core dumped)"

CC @matloob @samthanawalla

[gopherbot]

Sorry, but I can't find a watchflakes script at the start of the issue description.
See https://go.dev/wiki/Watchflakes for details.

— watchflakes

[matloob]

cc @golang/compiler

Assuming that the -toolexec flag isn't being passed in (and it doesn't look like it doing a quick glance at the test), it looks like the segfault is coming from the compiler. It's being invoked with the argument -V=full.

I tried running the test locally with tools and go at tip but couldn't reproduce. And it doesn't seem to be happening consistently on the builders.

[findleyr]

Thanks @matloob.

Absent a reproducer, this seems unactionable. Should we close and see if it recurs?

[matloob]

Sounds good.