Skip to content

x/tools/gopls: encountered "unsafe" as %s bug (via telemetry) #67751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adonovan opened this issue May 31, 2024 · 2 comments
Closed

x/tools/gopls: encountered "unsafe" as %s bug (via telemetry) #67751

adonovan opened this issue May 31, 2024 · 2 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

adonovan commented May 31, 2024

#!stacks
"bug.Reportf" && "cache.(*typeCheckBatch).checkPackage.func1:17"

This stack AXTUww was reported by telemetry:

storePackageResults:+17 is

// storePackageResults serializes and writes information derived from p to the
// file cache.
// The context is used only for logging; cancellation does not affect the operation.
func storePackageResults(ctx context.Context, ph *packageHandle, p *Package) {
...
	} else if p.metadata.ID != "unsafe" {
		// golang/go#60890: we should only ever see one variant of the "unsafe"
		// package.
		bug.Reportf("encountered \"unsafe\" as %s (golang/go#60890)", p.metadata.ID)
gopls/bug
golang.org/x/tools/gopls/internal/util/bug.report:+35
golang.org/x/tools/gopls/internal/util/bug.Reportf:+1
golang.org/x/tools/gopls/internal/cache.storePackageResults:+17
runtime.goexit:+0
golang.org/x/tools/[email protected] go1.22.0 darwin/arm64 other,vscode (1)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

Related:

@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels May 31, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2024
@adonovan adonovan changed the title x/tools/gopls: bug reported by telemetry x/tools/gopls: encountered "unsafe" as %s bug (via telemetry) May 31, 2024
@adonovan
Copy link
Member Author

Never mind, this is a straight-up dup of #60890.

@adonovan
Copy link
Member Author

adonovan commented Nov 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants