Skip to content

x/tools/gopls: regression of Organize Imports in CL 587555 #67823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adonovan opened this issue Jun 4, 2024 · 1 comment
Closed

x/tools/gopls: regression of Organize Imports in CL 587555 #67823

adonovan opened this issue Jun 4, 2024 · 1 comment
Assignees
@hyangah
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@adonovan
Copy link
Member

adonovan commented Jun 4, 2024

@hyangah points out that, in VS Code, organize imports on save stopped working at https://go.dev/cl/587555. I can reproduce it in VS Code.
@adonovan adonovan self-assigned this Jun 4, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 4, 2024
@adonovan adonovan added this to the gopls/v0.16.0 milestone Jun 4, 2024
@gopherbot gopherbot modified the milestones: gopls/v0.16.0, Unreleased Jun 4, 2024
@adonovan adonovan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 4, 2024
@hyangah hyangah mentioned this issue Jun 4, 2024
Closed
@hyangah hyangah modified the milestones: Unreleased, gopls/v0.16.0 Jun 4, 2024
@adonovan adonovan assigned hyangah and unassigned adonovan Jun 5, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/590935 mentions this issue: gopls/internal/server: fix regression in organize imports code action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@hyangah @adonovan @gopherbot