Skip to content

x/build/cmd/watchflakes: duplicate issue opened on package-level failure #68597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cherrymui opened this issue Jul 26, 2024 · 2 comments
Closed
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@cherrymui
Copy link
Member

Recently we added reporting package-level failures (that is not associated to a specific test) to LUCI. In some cases, e.g. at timeout, LUCI reports both test failures and package-level failures. E.g. https://ci.chromium.org/ui/p/golang/builders/ci/gotip-netbsd-arm64/b8745232168515795905/overview, which has failures for both os/exec.TestCancelErrors/killed_after_error and os/exec. Currently watchflakes reports two issues for them, in this case #68436 and #66895. We should not report the package-level one.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 26, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jul 26, 2024
@cherrymui cherrymui self-assigned this Jul 26, 2024
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 26, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/601436 mentions this issue: cmd/watchflakes: coalesce a package-level failure to a test failure in the same package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants