runtime.AddCleanup: Panic occurs when syscall.Close is called on macOS

[hxzhouh]

Go version

go version devel go1.24-1218566fe5 Mon Dec 16 18:19:39 2024 -0800 darwin/arm64

Output of go env in your module/workspace:

➜  AddCleanUp git:(main) ✗ go version
go version devel go1.24-1218566fe5 Mon Dec 16 18:19:39 2024 -0800 darwin/arm64
➜  AddCleanUp git:(main) ✗ gotip version 
go version devel go1.24-1218566 Mon Dec 16 18:19:39 2024 -0800 darwin/arm64

➜  AddCleanUp git:(main) ✗ go env 
AR='ar'
CC='clang'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CXX='clang++'
GCCGO='gccgo'
GO111MODULE='on'
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/hxzhouh/Library/Caches/go-build'
GODEBUG=''
GOENV='/Users/hxzhouh/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/ny/_2b7fvwx6v90sc44c8fbd0kr0000gn/T/go-build3735513723=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/Users/hxzhouh/workspace/github/me/blog-example/go.mod'
GOMODCACHE='/Users/hxzhouh/go/pkg/mod'
GOOS='darwin'
GOPATH='/Users/hxzhouh/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/Users/hxzhouh/workspace/github/golang/go'
GOSUMDB='sum.golang.org'
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/hxzhouh/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/hxzhouh/workspace/github/golang/go/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='devel go1.24-1218566fe5 Mon Dec 16 18:19:39 2024 -0800'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

source code:

• This code will not report errors on the go.dev and Linux systems.
• However, using the latest code and gossip on macOS will make it panic!
• Removing syscall.Close(int(fd)) from AddCleanup will not report an error!
• Calling syscall.read in AddCleanup doesn't give an error either!

What did you see happen?

please see the upload file
macos panic.txt
Please

What did you expect to see?

Don't Panic, Consistent with Linux

[gabyhelp]

Related Issues

• testing: panic swallowed if t.Cleanup calls t.Fatal #51395 (closed)
• runtime/pprof: panic: test timed out after 9m0s #52916 (closed)
• runtime: "fatal error: runtime: pipe failed" on macOS Big Sur #44941
• runtime: Panic in golang compiler on macOS Sierra Third Public Beta (16A270f) #16585 (closed)
• runtime: Unable to build go project on macOS 10.12 beta 4 #16575 (closed)
• cmd/compile: go build panic #20361 (closed)
• panic: runtime error Crash in Orphaned gorutines cant be handled #47261 (closed)
• runtime: GODEBUG=efence=1 causes panic during build on M1 #44993
• testing: misleading error message when a parallel Cleanup function calls runtime.Goexit #48502 (closed)
• runtime: signal 28 received on thread with no signal stack #22333 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[ianlancetaylor]

You are closing the file descriptor without calling the Close method of the File. This doesn't work. Don't try to mix and match syscall functions with os functions. In this case it is confusing the runtime network poller.

By the way, note that the os.File type already has a finalizer that will close the descriptor.