cmd/go build does not append +dirty

[andig]

What version of Go are you using (go version)?

$ go version
go version go1.24.0 darwin/arm64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output

$ go env
AR='ar'
CC='clang'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='clang++'
GCCGO='gccgo'
GO111MODULE=''
GOARCH='arm64'
GOARM64='v8.0'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/Users/andig/Library/Caches/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV='/Users/andig/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/sv/rs_453y57xj86xsbz3kw1mbc0000gn/T/go-build735142348=/tmp/go-build -gno-record-gcc-switches -fno-common'
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMOD='/Users/andig/htdocs/evcc/go.mod'
GOMODCACHE='/Users/andig/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='darwin'
GOPATH='/Users/andig/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/andig/go/pkg/mod/golang.org/[email protected]'
GOSUMDB='sum.golang.org'
GOTELEMETRY='on'
GOTELEMETRYDIR='/Users/andig/Library/Application Support/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/andig/go/pkg/mod/golang.org/[email protected]/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.24.0'
GOWORK=''
PKG_CONFIG='pkg-config'
GOROOT/bin/go version: go version go1.24.0 darwin/arm64
GOROOT/bin/go tool compile -V: compile version go1.24.0
uname -v: Darwin Kernel Version 24.3.0: Thu Jan  2 20:24:06 PST 2025; root:xnu-11215.81.4~3/RELEASE_ARM64_T8103
ProductName:		macOS
ProductVersion:		15.3
BuildVersion:		24D60
lldb --version: lldb-1600.0.39.109
Apple Swift version 6.0.3 (swiftlang-6.0.3.1.10 clang-1600.0.30.1)

What did you do?

I have build a main module with dirty tree. According to 1.24 release notes:

The go build command now sets the main module’s version in the compiled binary based on the version control system tag and/or commit. A +dirty suffix will be appended if there are uncommitted changes. Use the -buildvcs=false flag to omit version control information from the binary.

What did you expect to see?

+dirty appended (to commit?).

What did you see instead?

build	vcs=git
build	vcs.revision=29b1c882018c4a177247122f77d1073547707003
build	vcs.time=2025-02-12T12:07:29Z
build	vcs.modified=true

I prefer the vcs.modified over interfering with the commit, but then the release notes are inaccurate.

I also couldn't get a vcs.tag output even when HEAD was tagged.

[gabyhelp]

Related Issues

• runtime/debug: vcs.modified populated in ReadBuildInfo for go install but not go build #51637 (closed)
• go build uses wrong VCS information when running in a git worktree #64772 (closed)
• cmd/go: binary does not contain VCS information when compiled in git worktree dir #58218
• cmd/go: runtime/debug vcs build information not populated (OSX/git) #54042 (closed)
• runtime/debug: BuildInfo doesn't contain VCS info depending on the build command #68084 (closed)
• cmd/go: 1.20 broke buildvcs inside bare Git repositories with worktrees #59068 (closed)
• cmd/go: vcs info not stamped when built listing .go files directly #51279
• cmd/go: debug.BuildInfo doesn't include VCS info when cross-compiling [1.18rc1] #51264 (closed)
• cmd/go: go test -buildvcs=true does not include vcs information #52648 (closed)

Related Code Changes

• cmd/go: stamp VCS info when building .go files directly

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[seankhliao]

You're looking at the vcs info, not the module version.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions