Skip to content

x/tools/internal/typesinternal/typeindex: TestIndex failures [consistent failure] #73043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gopherbot opened this issue Mar 25, 2025 · 6 comments
Open

x/tools/internal/typesinternal/typeindex: TestIndex failures [consistent failure] #73043

gopherbot opened this issue Mar 25, 2025 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/typesinternal/typeindex" && test == "TestIndex"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 25, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/typesinternal/typeindex" && test == "TestIndex"
2025-03-25 16:11 x_tools-go1.24-js-wasm tools@19f73a60 release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 16:11 x_tools-go1.24-wasip1-wasm_wasmtime tools@19f73a60 release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 16:11 x_tools-go1.24-wasip1-wasm_wazero tools@19f73a60 release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 16:11 x_tools-gotip-js-wasm tools@19f73a60 go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 16:11 x_tools-gotip-wasip1-wasm_wasmtime tools@19f73a60 go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 16:11 x_tools-gotip-wasip1-wasm_wazero tools@19f73a60 go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 17:31 x_tools-go1.24-js-wasm tools@11a3153d release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.02s)
2025-03-25 17:31 x_tools-go1.24-wasip1-wasm_wasmtime tools@11a3153d release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 17:31 x_tools-go1.24-wasip1-wasm_wazero tools@11a3153d release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 17:31 x_tools-gotip-js-wasm tools@11a3153d go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 17:31 x_tools-gotip-wasip1-wasm_wasmtime tools@11a3153d go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 17:31 x_tools-gotip-wasip1-wasm_wazero tools@11a3153d go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:25 x_tools-go1.24-js-wasm tools@30641f5a release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 18:25 x_tools-go1.24-wasip1-wasm_wasmtime tools@30641f5a release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 18:25 x_tools-go1.24-wasip1-wasm_wazero tools@30641f5a release-branch.go1.24@311096a6 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:25 x_tools-gotip-js-wasm tools@30641f5a go@35c98648 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:25 x_tools-gotip-wasip1-wasm_wasmtime tools@30641f5a go@35c98648 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:25 x_tools-gotip-wasip1-wasm_wazero tools@30641f5a go@6bf95d40 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-go1.24-js-wasm tools@7efe9a8b release-branch.go1.24@dae59b59 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-go1.24-wasip1-wasm_wasmtime tools@7efe9a8b release-branch.go1.24@b7fd97ae x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-go1.24-wasip1-wasm_wazero tools@7efe9a8b release-branch.go1.24@dae59b59 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-gotip-js-wasm tools@7efe9a8b go@2bf57a35 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.01s)
2025-03-25 18:43 x_tools-gotip-wasip1-wasm_wasmtime tools@7efe9a8b go@2bf57a35 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-gotip-wasip1-wasm_wazero tools@7efe9a8b go@2bf57a35 x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 25, 2025
@gopherbot gopherbot added this to the Unreleased milestone Mar 25, 2025
@adonovan adonovan self-assigned this Mar 25, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/660735 mentions this issue: internal/typesinternal/typeindex: suppress test on js

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/typesinternal/typeindex" && test == "TestIndex"
2025-03-25 18:43 x_tools-gotip-js-wasm tools@7efe9a8b go@44fef2aa x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: not implemented on js: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-gotip-wasip1-wasm_wasmtime tools@7efe9a8b go@44fef2aa x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)
2025-03-25 18:43 x_tools-gotip-wasip1-wasm_wazero tools@7efe9a8b go@44fef2aa x/tools/internal/typesinternal/typeindex.TestIndex (log) 
=== RUN   TestIndex
    typeindex_test.go:74: err: pipe: Not implemented on wasip1: stderr: 
--- FAIL: TestIndex (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/typesinternal/typeindex" && test == "TestIndex"
2025-04-02 15:04 x_tools-gotip-windows-amd64-race tools@e74d252b go@13b12611 x/tools/internal/typesinternal/typeindex.TestIndex [ABORT] (log) 
=== RUN   TestIndex
fatal error: unexpected signal during runtime execution
[signal 0xc0000005 code=0x0 addr=0xe0 pc=0x140067025]

runtime stack:
runtime.throw({0x1404ef217?, 0x140733f40?})
	C:/b/s/w/ir/x/w/goroot/src/runtime/panic.go:1089 +0x4d fp=0x487ffb00 sp=0x487ffad0 pc=0x14007856d
runtime.sigpanic()
	C:/b/s/w/ir/x/w/goroot/src/runtime/signal_windows.go:387 +0x265 fp=0x487ffb48 sp=0x487ffb00 pc=0x14005a545
runtime.(*unwinder).next(0x487ffbf8)
...
fatal error: unexpected signal during runtime execution
panic during panic
[signal 0xc0000005 code=0x0 addr=0xe0 pc=0x140067025]

runtime stack:
runtime.throw({0x1404ef217?, 0x487ff368?})
	C:/b/s/w/ir/x/w/goroot/src/runtime/panic.go:1089 +0x4d fp=0x487ff328 sp=0x487ff2f8 pc=0x14007856d
runtime.sigpanic()
	C:/b/s/w/ir/x/w/goroot/src/runtime/signal_windows.go:387 +0x265 fp=0x487ff370 sp=0x487ff328 pc=0x14005a545
runtime.(*unwinder).next(0x487ff738)
...
runtime.markroot(0xc000031250, 0x32, 0x1)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:214 +0x199 fp=0x487ffdd0 sp=0x487ffd28 pc=0x140022d59
runtime.gcDrain(0xc000031250, 0x3)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:1186 +0x3d3 fp=0x487ffe38 sp=0x487ffdd0 pc=0x140025053
runtime.gcDrainMarkWorkerDedicated(...)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:1110
runtime.gcBgMarkWorker.func2()
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgc.go:1508 +0x9a fp=0x487ffe88 sp=0x487ffe38 pc=0x14002145a
runtime.systemstack(0xc00051e540)
	C:/b/s/w/ir/x/w/goroot/src/runtime/asm_amd64.s:512 +0x49 fp=0x487ffe98 sp=0x487ffe88 pc=0x14007e309

— watchflakes

@gopherbot gopherbot reopened this Apr 3, 2025
@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Apr 3, 2025
@adonovan
Copy link
Member

adonovan commented Apr 3, 2025

This latest crash is different, a crash during GC mark phase while unwinding the stack looking for roots, because the return address on the stack is invalid. In other words, stack corruption. I wonder whether this is a symptom of the unsound unsafe.Pointer conversions in the windows system call API (https://go.dev/cl/662575)? @qmuntal

fatal error: unexpected signal during runtime execution
[signal 0xc0000005 code=0x0 addr=0xe0 pc=0x140067025]

runtime stack:
runtime.throw({0x1404ef217?, 0x140733f40?})
	C:/b/s/w/ir/x/w/goroot/src/runtime/panic.go:1089 +0x4d fp=0x487ffb00 sp=0x487ffad0 pc=0x14007856d
runtime.sigpanic()
	C:/b/s/w/ir/x/w/goroot/src/runtime/signal_windows.go:387 +0x265 fp=0x487ffb48 sp=0x487ffb00 pc=0x14005a545
runtime.(*unwinder).next(0x487ffbf8)
	C:/b/s/w/ir/x/w/goroot/src/runtime/traceback.go:458 +0x105 fp=0x487ffbc0 sp=0x487ffb48 pc=0x140067025
runtime.scanstack(0xc000087180, 0xc000031250)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:904 +0x2c9 fp=0x487ffcd8 sp=0x487ffbc0 pc=0x1400245c9
runtime.markroot.func1()
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:240 +0xb1 fp=0x487ffd28 sp=0x487ffcd8 pc=0x1400230b1
runtime.markroot(0xc000031250, 0x32, 0x1)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:214 +0x199 fp=0x487ffdd0 sp=0x487ffd28 pc=0x140022d59
runtime.gcDrain(0xc000031250, 0x3)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:1186 +0x3d3 fp=0x487ffe38 sp=0x487ffdd0 pc=0x140025053
runtime.gcDrainMarkWorkerDedicated(...)
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgcmark.go:1110
runtime.gcBgMarkWorker.func2()
	C:/b/s/w/ir/x/w/goroot/src/runtime/mgc.go:1508 +0x9a fp=0x487ffe88 sp=0x487ffe38 pc=0x14002145a
runtime.systemstack(0xc00051e540)
	C:/b/s/w/ir/x/w/goroot/src/runtime/asm_amd64.s:512 +0x49 fp=0x487ffe98 sp=0x487ffe88 pc=0x14007e309

@qmuntal
Copy link
Member

qmuntal commented Apr 3, 2025 •
edited by gabyhelp
Loading

Might be relate, although this time there are no goroutines in os nor in runtime/poll. Although this could just mean that the goroutine manage to move leave the I/O-related functions without crashing but with a corrupted stack.

Let's merge the fix CL 662575 and see if this repeats again.

@adonovan adonovan mentioned this issue Apr 8, 2025
Open
@adonovan adonovan removed their assignment Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Active
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@qmuntal @adonovan @gopherbot