Skip to content

net: DNSError.IsTimeout almost never set #8748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
niemeyer opened this issue Sep 16, 2014 · 4 comments
Closed

net: DNSError.IsTimeout almost never set #8748

niemeyer opened this issue Sep 16, 2014 · 4 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone
Go1.5

Comments

@niemeyer
Copy link
Contributor 

The net.DNSError type has an IsTimeout field which seems to be set a single time inside
the Go-only resolver. Besides being public, this field is also the direct result of the
DNSError.Timeout and DNSError.Temporary methods, which means all three are always false
in a standard build, whether the error was a timeout or not.

Found that out while looking at issue #8602. Probably deserves to be documented, if not
fixed.
@rsc
Copy link
Contributor

rsc commented Sep 16, 2014

Comment 1:

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Oct 15, 2014

Comment 2:

Leaving alone for this release.

Labels changed: added release-go1.5, removed release-go1.4.

@niemeyer niemeyer added accepted Documentation Issues describing a change to documentation. labels Oct 15, 2014
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@rsc rsc removed accepted labels Apr 14, 2015
@jeffallen
Copy link
Contributor

I went to see if I could document this, and I found that as part of #4856, @mikioh seems to have already done this. If you agree with me, please mark issue a dup of #4856.

@ianlancetaylor
Copy link
Contributor

Agreed, thanks.

@golang golang locked and limited conversation to collaborators Jul 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
6 participants
@bradfitz @rsc @niemeyer @jeffallen @ianlancetaylor @gopherbot