Skip to content

There is no support for IPv6 records in the net package #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miekg opened this issue Aug 4, 2010 · 2 comments
Closed

There is no support for IPv6 records in the net package #996

miekg opened this issue Aug 4, 2010 · 2 comments

Comments

@miekg
Copy link
Contributor

miekg commented Aug 4, 2010

The net package has a fairly complete dns implementation, however it lacks
support for IPv6 (AAAA) records. The following patch adds support for this. 
It does so by redefining A and now also AAAA as IP structs.

The pack and unpack function are modified accordingly. The unpack function works, but I
could not yet test the pack function. 'make test' in the net/ directory is still OK.

LookupHost also needs to be modified to make IPv6 actually work. Currently it still
looks for A records.

Attachments:

  1. go.net.ipv6.patch (5687 bytes)
@adg
Copy link
Contributor

adg commented Aug 6, 2010

Comment 1:

Please submit these changes as a CL:
 http://golang.org/doc/contribute.html

Labels changed: added packagechange.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Apr 5, 2011

Comment 2:

*** Submitted as
http://code.google.com/p/go/source/detail?r=5db33d4b32f6 ***
net: drop laddr from Dial, cname from LookupHost; new functions
Drop laddr argument from Dial.
Drop cname return from LookupHost.
Add LookupIP, LookupCNAME, ParseCIDR, IP.Equal.
Export SplitHostPort, JoinHostPort.
Add AAAA (IPv6) support to host lookups.
Preparations for implementing some of the
lookups using cgo.
ParseCIDR and IP.Equal are logically new in this CL
but accidentally snuck into an earlier CL about unused
labels that was in the same client.
In crypto/tls, drop laddr from Dial to match net.
R=golang-dev, dsymonds, adg, rh
CC=golang-dev
http://golang.org/cl/4244055

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants