Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Commit 25d1a55

Browse files
committed
print key, value and error in t.Errorf()
1 parent 2ccc686 commit 25d1a55

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

mockgen/parse_test.go

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func TestParsePackageImport(t *testing.T) {
169169
for key, value := range testCase.envs {
170170
err = os.Setenv(key, value)
171171
if err != nil {
172-
t.Errorf("unexpected error: %s", err.Error())
172+
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
173173
}
174174
}
175175
pkgPath, err := parsePackageImport(filepath.Clean(testCase.dir))
@@ -198,13 +198,17 @@ func TestParsePackageImport_FallbackGoPath(t *testing.T) {
198198
if err != nil {
199199
t.Error(err)
200200
}
201-
err = os.Setenv("GOPATH", goPath)
201+
key := "GOPATH"
202+
value := goPath
203+
err = os.Setenv(key, value)
202204
if err != nil {
203-
t.Errorf("unexpected error: %s", err.Error())
205+
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
204206
}
205-
err = os.Setenv("GO111MODULE", "on")
207+
key = "GO111MODULE"
208+
value = "on"
209+
err = os.Setenv(key, value)
206210
if err != nil {
207-
t.Errorf("unexpected error: %s", err.Error())
211+
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
208212
}
209213
pkgPath, err := parsePackageImport(srcDir)
210214
expected := "example.com/foo"
@@ -246,13 +250,17 @@ func TestParsePackageImport_FallbackMultiGoPath(t *testing.T) {
246250
}()
247251

248252
goPaths := strings.Join(goPathList, string(os.PathListSeparator))
249-
err = os.Setenv("GOPATH", goPaths)
253+
key := "GOPATH"
254+
value := goPaths
255+
err = os.Setenv(key, value)
250256
if err != nil {
251-
t.Errorf("unexpected error: %s", err.Error())
257+
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
252258
}
253-
err = os.Setenv("GO111MODULE", "on")
259+
key = "GO111MODULE"
260+
value = "on"
261+
err = os.Setenv(key, value)
254262
if err != nil {
255-
t.Errorf("unexpected error: %s", err.Error())
263+
t.Fatalf("unable to set environment variable %q to %q: %v", key, value, err)
256264
}
257265
pkgPath, err := parsePackageImport(srcDir)
258266
expected := "example.com/foo"

0 commit comments

Comments
 (0)