Skip to content

Commit fe7b566

Browse files
committed
Merge pull request #287 from zhangkun83/protoc-artifacts-fixup
A few fix-ups for protoc-artifacts
2 parents ba05454 + 90a7ed6 commit fe7b566

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

Diff for: protoc-artifacts/README.md

+7-3
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ deployment for all platforms. Currently the following platforms are supported:
6363
- MSYS with MinGW32 (x86_32 only)
6464
- MacOSX (x86_32 and x86_64)
6565

66-
Remove any ``SNAPSHOT`` or ``pre`` suffix from the version string before
67-
deploying.
68-
6966
Use the following command to deploy artifacts for the host platform to a
7067
staging repository.
7168
```
@@ -118,3 +115,10 @@ stored:
118115
</activeProfiles>
119116
</settings>
120117
```
118+
119+
### Tested build environments
120+
We have succesfully built artifacts on the following environments:
121+
- Linux x86_32 and x86_64: Ubuntu 14.04.2 64-bit
122+
- Windows x86_32: MSYS with ``mingw32-gcc-g++ 4.8.1-4`` on Windows 7 64-bit
123+
- Windows x86_64: Cygwin64 with ``mingw64-x86_64-gcc-g++ 4.8.3-1`` on Windows 7 64-bit
124+
- Mac OS X x86_32 and x86_64: Mac OS X 10.9.5

Diff for: protoc-artifacts/build-protoc.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,9 @@ if [[ "$(uname)" == CYGWIN* ]]; then
158158
elif [[ "$(uname)" == MINGW32* ]]; then
159159
assertEq "$OS" windows $LINENO
160160
assertEq "$ARCH" x86_32 $LINENO
161+
elif [[ "$(uname)" == MINGW64* ]]; then
162+
assertEq "$OS" windows $LINENO
163+
assertEq "$ARCH" x86_64 $LINENO
161164
elif [[ "$(uname)" == Linux* ]]; then
162165
if [[ "$OS" == linux ]]; then
163166
if [[ "$ARCH" == x86_64 ]]; then
@@ -209,7 +212,7 @@ export CXXFLAGS LDFLAGS
209212
TARGET_FILE=target/protoc.exe
210213

211214
cd "$WORKING_DIR"/.. && ./configure $CONFIGURE_ARGS &&
212-
cd src && make clean && make $MAKE_TARGET &&
215+
cd src && make clean && make google/protobuf/stubs/pbconfig.h $MAKE_TARGET &&
213216
cd "$WORKING_DIR" && mkdir -p target &&
214217
(cp ../src/protoc $TARGET_FILE || cp ../src/protoc.exe $TARGET_FILE) ||
215218
exit 1

0 commit comments

Comments
 (0)