Skip to content

Commit 41c411d

Browse files
author
Bryan C. Mills
committed
internal/lsp/testdata: remove diagnostic from percent package
The percent package has an invalid import path and a disallowed character in a source file. In CL 258298, I am changing cmd/go to diagnose invalid import paths during loading (instead of during missing-import resolution), and as a result 'go list' will no longer attempt to load or enumerate the source files for that package. It is important that gopls and 'go list' not crash when attempting to load a package with an invalid path, but gopls should not assume that 'go list' will produce anything more than an error for it. For golang/go#37438 For golang/go#41576 Change-Id: I8af8896ea7108f1588e0085ddc1bf1b9ff55d5b9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/258717 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent 77e61d3 commit 41c411d

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed
Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1 @@
11
package percent
2-
3-
import (
4-
)
5-
6-
func _() {
7-
var x int //@diag("x", "compiler", "x declared but not used", "error")
8-
}

internal/lsp/testdata/summary.txt.golden

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ DeepCompletionsCount = 5
88
FuzzyCompletionsCount = 8
99
RankedCompletionsCount = 157
1010
CaseSensitiveCompletionsCount = 4
11-
DiagnosticsCount = 44
11+
DiagnosticsCount = 43
1212
FoldingRangesCount = 2
1313
FormatCount = 6
1414
ImportCount = 8

0 commit comments

Comments
 (0)