Skip to content

Commit 4cd12d6

Browse files
findleyrgopherbot
authored andcommitted
gopls/internal/lsp/fake: don't set a completion budget for tests
We were already setting an arbitrarily high completion budget of 10s for tests, but this appears to be causing flakes in the heavily parallelized marker tests on slow builders (e.g. golang/go#60584). No reason to have any budget at all: any tests/benchmarks that depend on the budget should set it explicitly. For golang/go#60584 Change-Id: Ic5e84d483fdffb58b801aae7b814ff705e6ecee9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/531556 Auto-Submit: Robert Findley <[email protected]> Reviewed-by: Peter Weinberger <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 57ecf48 commit 4cd12d6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

gopls/internal/lsp/fake/editor.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,9 @@ func makeSettings(sandbox *Sandbox, config EditorConfig) map[string]interface{}
235235
// asynchronous operations being completed (such as diagnosing a snapshot).
236236
"verboseWorkDoneProgress": true,
237237

238-
// Set a generous completion budget, so that tests don't flake because
238+
// Set an unlimited completion budget, so that tests don't flake because
239239
// completions are too slow.
240-
"completionBudget": "10s",
240+
"completionBudget": "0s",
241241
}
242242

243243
for k, v := range config.Settings {

0 commit comments

Comments
 (0)