Skip to content

Commit 77362c5

Browse files
dmitshurmatloob
authored andcommitted
go/packages: replace darwin with netbsd in TestSizes
The darwin/386 port has been removed per golang.org/issue/37610. TestSizes needs an operating system that has both amd64 and 386 ports, so darwin no longer qualifies. NetBSD has had its 386 port restored recently in golang/go#31726, so it can be used instead. Fixes golang/go#38319. For golang/go#37610. Change-Id: I37ce6d86ca3ddad43e9294e0de66f36091cba54a Reviewed-on: https://go-review.googlesource.com/c/tools/+/227552 Reviewed-by: Benny Siegert <[email protected]>
1 parent 9ee5ef7 commit 77362c5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

go/packages/packages_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1584,12 +1584,12 @@ func testContainsOverlayXTest(t *testing.T, exporter packagestest.Exporter) {
15841584
// This test ensures that the effective GOARCH variable in the
15851585
// application determines the Sizes function used by the type checker.
15861586
// This behavior is a stop-gap until we make the build system's query
1587-
// too report the correct sizes function for the actual configuration.
1587+
// tool report the correct sizes function for the actual configuration.
15881588
func TestSizes(t *testing.T) { packagestest.TestAll(t, testSizes) }
15891589
func testSizes(t *testing.T, exporter packagestest.Exporter) {
15901590
// Only run this test on operating systems that have both an amd64 and 386 port.
15911591
switch runtime.GOOS {
1592-
case "darwin", "linux", "windows", "freebsd", "openbsd", "android":
1592+
case "linux", "windows", "freebsd", "openbsd", "netbsd", "android":
15931593
default:
15941594
t.Skipf("skipping test on %s", runtime.GOOS)
15951595
}

0 commit comments

Comments
 (0)