Skip to content

Commit 7b6ac5b

Browse files
committed
internal/lsp/cache: slightly more useful comment
Explain why we're ignoring errors, not just that we are. Change-Id: I6cbb4945ef6066180953dcaba6f561843d7f20a1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/256820 Trust: Heschi Kreinick <[email protected]> Run-TryBot: Heschi Kreinick <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]>
1 parent 24570c0 commit 7b6ac5b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

internal/lsp/cache/session.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,8 +260,8 @@ func findWorkspaceModules(ctx context.Context, root span.URI, options *source.Op
260260
// Walk the view's folder to find all modules in the view.
261261
modules := make(map[span.URI]*moduleRoot)
262262
return modules, filepath.Walk(root.Filename(), func(path string, info os.FileInfo, err error) error {
263-
// Ignore any errors we may encounter while visiting files.
264263
if err != nil {
264+
// Probably a permission error. Keep looking.
265265
return filepath.SkipDir
266266
}
267267
// For any path that is not the workspace folder, check if the path

0 commit comments

Comments
 (0)