internal/lsp/source: use logical filenames for workspace symbols

We need to use the filename derived from the symbol information, not the
one from CompiledGoFiles, in case of cgo packages.

No tests because workspace symbols are entangled with document symbols,
and the latter doesn't work in cgo packages.

Fixes golang/go#37659.

Change-Id: Ic32293c542830a49b37c25ebf3b231771c3a4225
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222060
Run-TryBot: Heschi Kreinick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>

Author: heschi

internal/lsp/source/workspace_symbol.go

@@ -47,16 +47,21 @@ outer:
 					return nil, err
 				}
 				for _, si := range findSymbol(file.Decls, pkg.GetTypesInfo(), matcher) {
-					rng, err := nodeToProtocolRange(view, pkg, si.node)
+					mrng, err := posToMappedRange(view, pkg, si.node.Pos(), si.node.End())
 					if err != nil {
-						log.Error(ctx, "Error getting range for node", err)
+						log.Error(ctx, "Error getting mapped range for node", err)
+						continue
+					}
+					rng, err := mrng.Range()
+					if err != nil {
+						log.Error(ctx, "Error getting range from mapped range", err)
 						continue
 					}
 					symbols = append(symbols, protocol.SymbolInformation{
 						Name: si.name,
 						Kind: si.kind,
 						Location: protocol.Location{
-							URI:   protocol.URIFromSpanURI(fh.File().Identity().URI),
+							URI:   protocol.URIFromSpanURI(mrng.URI()),
 							Range: rng,
 						},
 					})