Skip to content

Commit dca7638

Browse files
author
Bryan C. Mills
committed
go/ssa/interp: skip failing test
This test introduces noise when using 'go test all' or 'go test ./...' to test go/packages and the tools that depend on it. Since it has been broken for around a month, skip it indefinitely. Updates golang/go#27292 Change-Id: I796292310332712e14bc8a0b73e36a8ed6f8a73f Reviewed-on: https://go-review.googlesource.com/137315 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent ff3f684 commit dca7638

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

go/ssa/interp/interp_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ var gorootTestTests = []string{
103103
"floatcmp.go",
104104
"crlf.go", // doesn't actually assert anything (runoutput)
105105
// Slow tests follow.
106-
"bom.go", // ~1.7s
107-
"gc1.go", // ~1.7s
106+
"bom.go", // ~1.7s
107+
"gc1.go", // ~1.7s
108108
"cmplxdivide.go cmplxdivide1.go", // ~2.4s
109109

110110
// Working, but not worth enabling:
@@ -156,9 +156,7 @@ var testdataTests = []string{
156156
type successPredicate func(exitcode int, output string) error
157157

158158
func run(t *testing.T, dir, input string, success successPredicate) bool {
159-
if testing.Short() {
160-
t.Skip("test breaks regularly; skipping in short mode so a failure doesn't affect trybots or build.golang.org; golang.org/issue/27292")
161-
}
159+
t.Skip("golang.org/issue/27292")
162160
if runtime.GOOS == "darwin" {
163161
t.Skip("skipping on darwin until golang.org/issue/23166 is fixed")
164162
}

0 commit comments

Comments
 (0)